Skip to content

Feature/2886 general site settings#2971

Closed
tonyr59h wants to merge 19 commits intodevelopfrom
feature/2886-general-site-settings
Closed

Feature/2886 general site settings#2971
tonyr59h wants to merge 19 commits intodevelopfrom
feature/2886-general-site-settings

Conversation

@tonyr59h
Copy link
Copy Markdown
Contributor

Addresses #2886. Introduces most of the General Site Settings for WordPress.com, site address changes is not implemented.

The other sections are in active development but I wanted to get the completed parts tested ASAP to stabilize before the 4.4 release.

@tonyr59h tonyr59h added this to the 4.4 milestone Jul 14, 2015
@nbradbury nbradbury self-assigned this Jul 15, 2015
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard-coded string here. Also, it would be good to write the error to the AppLog.

@nbradbury
Copy link
Copy Markdown
Contributor

  • The design looks quite a bit different than Matt Miklic's card-based design. Was that design dropped?
  • This is missing the media settings that existed in the previous version - safe to assume these will be added in a separate PR also targeted for v4.4?
  • The Undo button in the toolbar seems really out of place, especially when the screen is first shown and the user hasn't even changed anything. My vote would be to drop undo entirely - it doesn't seem necessary, and I don't think I've seen Undo in any app's settings before.
  • I get a "Fragment SiteSettingsFragment{3db9ed66} not attached to Activity" IllegalStateException if I rotate the device while site settings is showing.
  • I get a toast saying, "Error getting site info" whenever I try to view the settings for my self-hosted blog (looks like an auth error). When that happens, I'm left with a screen that has nothing filled in, and backing out results in a crash (NPE in SiteSettingsFragment.generatePostParams). Video demo here.
  • I can repro the above problem by putting the device in airplane mode and opening site settings. If I enable airplane mode after site settings is displayed, I can edit the site title, tagline, etc., and it acts as though the changes have been saved even though they haven't.

@tonyr59h
Copy link
Copy Markdown
Contributor Author

This is missing the media settings that existed in the previous version - safe to assume these will be added in a separate PR also targeted for v4.4?

Yes! Thank you for the reminder, I'll open a ticket for it.

The design looks quite a bit different than Matt Miklic's card-based design. Was that design dropped?

I'll be shuffling the design up in the next two PRs (coming soon) to keep it in line with the discussion. I decided to submit with what Android gives us based on @roundhill's feedback: Sounds like a good idea to me, just keep it native using whatever PreferenceFragment provides. I’m doing something similar for the new notifications control center.

@tonyr59h
Copy link
Copy Markdown
Contributor Author

Re-opening to merge into different branch.

@tonyr59h tonyr59h closed this Jul 15, 2015
wzieba pushed a commit that referenced this pull request Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants