Skip to content

Update kotlin version to 1.6.0#15642

Closed
oguzkocer wants to merge 5 commits intodevelopfrom
update/kotlin-version-to-1.6.0
Closed

Update kotlin version to 1.6.0#15642
oguzkocer wants to merge 5 commits intodevelopfrom
update/kotlin-version-to-1.6.0

Conversation

@oguzkocer
Copy link
Copy Markdown
Contributor

@oguzkocer oguzkocer commented Dec 2, 2021

This PR updates kotlin to the latest version 1.6.0. We had some failures related to the kotlin version today in #15641 and instead of addressing that with a temporary solution, I decided to put in the time to update to the latest version. Here is a summary of the changes:

  • Updates kotlinVersion to 1.6.0 & coroutinesVersion to 1.5.2
  • Updates daggerVersion to 2.40.3 to fix build errors due to kotlin version update
  • Specifies com.android.tools:r8 version to fix this issue: https://issuetracker.google.com/issues/194915678
  • Replaces deprecated maxBy with maxByOrNull
  • Removes ExperimentalStdlibApi annotation as it's no longer necessary in our case
  • Removes InternalCoroutinesApi & ExperimentalCoroutinesApi annotations from a few classes where they weren't necessary (I don't think I got them all, but I didn't want to sink more time into this PR)
  • Replaces deprecated UseExperimental with OptIn

To test:
Smoke test the app. It's unlikely that these changes will have any impact on the application as the changes should be limited to compilation. Unfortunately there is no good way to verify that, so I think all we can do is smoke test the app and address anything that might come up in the future.

Regression Notes

  1. Potential unintended areas of impact
  • Compile errors that might not be covered by our regular CI integration (such as release builds)
  • Possibly some issues in the app, but I think this is very unlikely and there is no specific area to focus
  1. What I did to test those areas of impact (or what existing automated tests I relied on)
  • Smoke tested the app and mainly focused on getting successful builds in CI & local environment.
  1. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Dec 2, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@oguzkocer oguzkocer force-pushed the update/kotlin-version-to-1.6.0 branch from 5a8d1ed to 4d04277 Compare December 2, 2021 02:42
@oguzkocer oguzkocer force-pushed the update/kotlin-version-to-1.6.0 branch from 4d04277 to fe7ca06 Compare December 2, 2021 03:24
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Dec 2, 2021

You can test the changes on this Pull Request by downloading the APKs:

@oguzkocer oguzkocer force-pushed the update/kotlin-version-to-1.6.0 branch from 8a2ad66 to 1355d4c Compare December 2, 2021 05:13
@oguzkocer oguzkocer force-pushed the update/kotlin-version-to-1.6.0 branch from 1355d4c to f0dfa79 Compare December 2, 2021 05:25
@oguzkocer oguzkocer added Tooling and removed Tooling labels Dec 2, 2021
@oguzkocer oguzkocer marked this pull request as ready for review December 2, 2021 06:05
@oguzkocer oguzkocer requested review from a team, khaykov and ravishanker December 2, 2021 06:05
@oguzkocer oguzkocer added this to the 18.9 milestone Dec 2, 2021
@AliSoftware
Copy link
Copy Markdown
Contributor

AliSoftware commented Dec 2, 2021

This PR was superseded by #15646 which only bump kotlin to 1.5.32 instead of 1.6.0. This is after discussing it with @ParaskP7 in Slack (ref: p1638446584150000/1638445699.148800-slack-C02QANACA)

We can still consider applying the other changes you made (removal of obsolete annotations, etc) at some point, but we preferred to take the safe route wrt fixing the compilation issue ASAP first, and then take our time to consider the (potentially breaking) other changes as a second phase only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants