Closed
Conversation
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
5a8d1ed to
4d04277
Compare
4d04277 to
fe7ca06
Compare
|
You can test the changes on this Pull Request by downloading the APKs: |
8a2ad66 to
1355d4c
Compare
1355d4c to
f0dfa79
Compare
3 tasks
3 tasks
Contributor
|
This PR was superseded by #15646 which only bump kotlin to 1.5.32 instead of 1.6.0. This is after discussing it with @ParaskP7 in Slack (ref: p1638446584150000/1638445699.148800-slack-C02QANACA) We can still consider applying the other changes you made (removal of obsolete annotations, etc) at some point, but we preferred to take the safe route wrt fixing the compilation issue ASAP first, and then take our time to consider the (potentially breaking) other changes as a second phase only. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates kotlin to the latest version
1.6.0. We had some failures related to the kotlin version today in #15641 and instead of addressing that with a temporary solution, I decided to put in the time to update to the latest version. Here is a summary of the changes:kotlinVersionto1.6.0&coroutinesVersionto1.5.2daggerVersionto2.40.3to fix build errors due to kotlin version updatecom.android.tools:r8version to fix this issue: https://issuetracker.google.com/issues/194915678maxByOrNullExperimentalStdlibApiannotation as it's no longer necessary in our caseInternalCoroutinesApi&ExperimentalCoroutinesApiannotations from a few classes where they weren't necessary (I don't think I got them all, but I didn't want to sink more time into this PR)OptInTo test:
Smoke test the app. It's unlikely that these changes will have any impact on the application as the changes should be limited to compilation. Unfortunately there is no good way to verify that, so I think all we can do is smoke test the app and address anything that might come up in the future.
Regression Notes
N/A
PR submission checklist:
RELEASE-NOTES.txtif necessary.