Skip to content

Removed UC Details FF flag from wasabi build.#15641

Merged
develric merged 5 commits intodevelopfrom
issue/disable-uc-details-ff-in-wasabi
Dec 3, 2021
Merged

Removed UC Details FF flag from wasabi build.#15641
develric merged 5 commits intodevelopfrom
issue/disable-uc-details-ff-in-wasabi

Conversation

@khaykov
Copy link
Copy Markdown
Contributor

@khaykov khaykov commented Dec 1, 2021

Since we are postponing Unified Comment details, I'm removing the FF from the wasabi build.

To test:

  • Install wasabi build.
  • Make sure comment details have some content and not just an empty fragment.

Regression Notes

  1. Potential unintended areas of impact
    None.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manual testing.

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Dec 1, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@oguzkocer oguzkocer mentioned this pull request Dec 2, 2021
3 tasks
@peril-wordpress-mobile
Copy link
Copy Markdown

You can test the changes on this Pull Request by downloading the APKs:

Copy link
Copy Markdown
Contributor

@develric develric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @khaykov 👋 , works as described and LGTM 👍 !

@develric develric merged commit eab9ded into develop Dec 3, 2021
@develric develric deleted the issue/disable-uc-details-ff-in-wasabi branch December 3, 2021 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants