Build: Update kotlin and coroutines to 1.5.32 and 1.5.2 respectively#15646
Merged
AliSoftware merged 1 commit intodevelopfrom Dec 2, 2021
Merged
Build: Update kotlin and coroutines to 1.5.32 and 1.5.2 respectively#15646AliSoftware merged 1 commit intodevelopfrom
AliSoftware merged 1 commit intodevelopfrom
Conversation
As part of this update 'maxBy' was replaced by 'maxByOrNull', but other than that everything else remained the same.
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
3 tasks
|
You can test the changes on this Pull Request by downloading the APKs: |
khaykov
approved these changes
Dec 2, 2021
Contributor
khaykov
left a comment
There was a problem hiding this comment.
Smoked tested all the main screens and everything looks good so far 👍
Will leave the merging up to you :)
Contributor
Author
|
Did some quick test on my end too, so I'm now merging – develop has been blocked broken for long enough, let's land this fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems the build has recently started to fail on
develop(andrelease/18.8) recently with the following error:This PR attempts to fix this by updating kotlin to the latest stable 1.5.32.
This superseeds #15642, at least for now, since @ParaskP7 raised concerns that updating to kotlin 1.6.0 and jumping 2 versions at once could be a bit too dangerous, as there are apparently some issues with the latest Kotlin release. We could always consider still bumping to 1.6.0 in a later PR.
As part of this update, 'maxBy' was replaced by 'maxByOrNull', but other than that everything else remained the same.
h/t @ParaskP7 for doing all the legwork.
To test
Smoke test the app.
It's unlikely that these changes will have any impact on the application as the changes should be limited to compilation. Unfortunately there is no good way to verify that, so I think all we can do is smoke test the app and address anything that might come up in the future.
Regression Notes
N/A
PR submission checklist:
RELEASE-NOTES.txtif necessary.