Skip to content

Build: Update kotlin and coroutines to 1.5.32 and 1.5.2 respectively#15646

Merged
AliSoftware merged 1 commit intodevelopfrom
update/kotlin-version-to-1.5.32
Dec 2, 2021
Merged

Build: Update kotlin and coroutines to 1.5.32 and 1.5.2 respectively#15646
AliSoftware merged 1 commit intodevelopfrom
update/kotlin-version-to-1.5.32

Conversation

@AliSoftware
Copy link
Copy Markdown
Contributor

@AliSoftware AliSoftware commented Dec 2, 2021

It seems the build has recently started to fail on develop (and release/18.8) recently with the following error:

e: …/libs/editor/WordPressEditor/src/main/java/org/wordpress/android/editor/gutenberg/GutenbergDialogFragment.kt: (41, 9): Class 'kotlin.Unit' was compiled with an incompatible version of Kotlin. The binary version of its metadata is 1.6.0, expected version is 1.4.2.

This PR attempts to fix this by updating kotlin to the latest stable 1.5.32.

This superseeds #15642, at least for now, since @ParaskP7 raised concerns that updating to kotlin 1.6.0 and jumping 2 versions at once could be a bit too dangerous, as there are apparently some issues with the latest Kotlin release. We could always consider still bumping to 1.6.0 in a later PR.

As part of this update, 'maxBy' was replaced by 'maxByOrNull', but other than that everything else remained the same.

h/t @ParaskP7 for doing all the legwork.

To test

Smoke test the app.

It's unlikely that these changes will have any impact on the application as the changes should be limited to compilation. Unfortunately there is no good way to verify that, so I think all we can do is smoke test the app and address anything that might come up in the future.

Regression Notes

  1. Potential unintended areas of impact
  • Compile errors that might not be covered by our regular CI integration (such as release builds)
  • Possibly some issues in the app, but hopefully unlikely and there is no specific area to focus
  1. What I did to test those areas of impact (or what existing automated tests I relied on)
  • Mainly focused on getting successful builds in CI & local environment.
  1. What automated tests I added (or what prevented me from doing so)

N/A


PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

As part of this update 'maxBy' was replaced by 'maxByOrNull', but other
than that everything else remained the same.
@peril-wordpress-mobile
Copy link
Copy Markdown

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@AliSoftware AliSoftware mentioned this pull request Dec 2, 2021
3 tasks
@AliSoftware AliSoftware added this to the 18.9 milestone Dec 2, 2021
@AliSoftware AliSoftware added 1 and removed 1 labels Dec 2, 2021
@peril-wordpress-mobile
Copy link
Copy Markdown

You can test the changes on this Pull Request by downloading the APKs:

Copy link
Copy Markdown
Contributor

@khaykov khaykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smoked tested all the main screens and everything looks good so far 👍

Will leave the merging up to you :)

@AliSoftware AliSoftware merged commit 4dae40f into develop Dec 2, 2021
@AliSoftware AliSoftware deleted the update/kotlin-version-to-1.5.32 branch December 2, 2021 18:14
@AliSoftware
Copy link
Copy Markdown
Contributor Author

Did some quick test on my end too, so I'm now merging – develop has been blocked broken for long enough, let's land this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants