Skip to content

Jetpack Scan: Apply copy improvements#13990

Merged
ashiagr merged 2 commits intodevelopfrom
issue/13326-scan-copy-improvements
Feb 8, 2021
Merged

Jetpack Scan: Apply copy improvements#13990
ashiagr merged 2 commits intodevelopfrom
issue/13326-scan-copy-improvements

Conversation

@ashiagr
Copy link
Copy Markdown
Contributor

@ashiagr ashiagr commented Feb 8, 2021

Fixes #13916

This PR applies copy improvements for the Jetpack Scan section:

  1. The scan found [N] potential threats with [SiteName]. Please review them below and take action. We are here to help if you need us. -> The scan found [N] potential threats with [SiteName]. Please review them below and take action or tap the fix all button. We are here to help if you need us.

  2. The last jetpack scan ran just now and everything looked great. Run a manual scan now or wait for Jetpack to scan your site later today. -> The last jetpack scan did not find any risks. To review your site again run a manual scan, or wait for Jetpack to scan your site later today.

Not Applicable

  1. Don’t worry about a thing -> Risks Removed. (Not needed as per Jetpack Section: Update copy with editorial text WordPress-iOS#15790 (comment))

    There was a slight change in the fix threats flow and these messages do not exist now (Compared with iOS here):

  2. You resolved 2 threats just now and everything looked great. Run a manual scan now or wait for Jetpack to scan your site later today. -> You resolved the 2 threats listed below and your site is now risk free.. To review your site again run a manual scan, or wait for Jetpack to scan your site later today.

  3. You resolved [N] threats just now -> You resolved [N] threats

Merge Instructions

I targeted 16.8 milestone as changes are not critical but it'll great if it can be merged in 16.7.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@ashiagr ashiagr added this to the 16.8 milestone Feb 8, 2021
@ashiagr ashiagr requested a review from ParaskP7 February 8, 2021 02:50
@ashiagr ashiagr self-assigned this Feb 8, 2021
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Feb 8, 2021 •
edited
Loading

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Feb 8, 2021 •
edited
Loading

You can test the changes on this Pull Request by downloading the APK here.

@ParaskP7 ParaskP7 self-assigned this Feb 8, 2021
ParaskP7
ParaskP7 approved these changes Feb 8, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@ParaskP7 ParaskP7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 @ashiagr !

I have reviewed this PR as per the instruction, everything looks good! 🌟

I have left a couple of question (❓) for you since I am not sure about them. I am going to approve this PR anyway, since those question might have already been answered. I am NOT going to merge this PR yet since I am unsure. However, feel free to ignore them and merge the PR yourself.

PS: About the Not Applicable section.

Don’t worry about a thing -> Risks Removed. (Not needed as per wordpress-mobile/WordPress-iOS#15790 (comment))
There was a slight change in the fix threats flow and these messages do not exist now (Compared with iOS here):

👌

You resolved 2 threats just now and everything looked great. Run a manual scan now or wait for Jetpack to scan your site later today. -> You resolved the 2 threats listed below and your site is now risk free.. To review your site again run a manual scan, or wait for Jetpack to scan your site later today.

Not sure about that, can you elaborate how these are not applicable, is it because they don't even exist?

You resolved [N] threats just now -> You resolved [N] threats

Same here. Not sure about that, can you elaborate how these are not applicable, is it because they don't even exist?

@ashiagr
Copy link
Copy Markdown
Contributor Author

ashiagr commented Feb 8, 2021 •
edited
Loading

Thanks for the review @ParaskP7!

Regarding your questions:

You resolved 2 threats just now and everything looked great. Run a manual scan now or wait for Jetpack to scan your site later today. -> You resolved the 2 threats listed below and your site is now risk free.. To review your site again run a manual scan, or wait for Jetpack to scan your site later today.

Not sure about that, can you elaborate how these are not applicable, is it because they don't even exist?

Yes they don't exist and so are not applicable. I mentioned in the description (I should've used nested lists 😅):
"There was a slight change in the fix threats flow and these messages do not exist now"

You resolved [N] threats just now -> You resolved [N] threats

Same here. Not sure about that, can you elaborate how these are not applicable, is it because they don't even exist?

Yes they don't exist and so are not applicable.

Ready for another look.

@ParaskP7
Copy link
Copy Markdown
Contributor

ParaskP7 commented Feb 8, 2021 •
edited
Loading

Yes they don't exist and so are not applicable. I mentioned in the description (I should've used nested lists 😅):
"There was a slight change in the fix threats flow and these messages do not exist now"

Thanks for the clarification @ashiagr ! 🙏

Ready for another look.

LGTM, feel free to merge this PR when you are ready and get a confirmation from @osullivanchris as well! 🌟

@ashiagr ashiagr merged commit 8da09af into develop Feb 8, 2021
@ashiagr ashiagr deleted the issue/13326-scan-copy-improvements branch February 8, 2021 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ParaskP7 ParaskP7 ParaskP7 approved these changes

+1 more reviewer

@osullivanchris osullivanchris osullivanchris left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@ashiagr ashiagr

@ParaskP7 ParaskP7

Labels

None yet

Projects

None yet

Milestone

16.8

Development

Successfully merging this pull request may close these issues.

Copy improvements for Jetpack Section

3 participants

@ashiagr @ParaskP7 @osullivanchris