Jetpack Section: Update copy with editorial text by emilylaguna · Pull Request #15790 · wordpress-mobile/WordPress-iOS

emilylaguna · 2021-02-04T16:32:47Z

Project: #15193
Fixes #15741

To test:

🟢 Build
Review copy changes and verify there are no typos or mistakes
Run through the Backup flow to verify the copy changes don't break the layout
Run through the Restore flow to verify the copy changes don't break the layout
Run through the Scan flow to verify the copy changes don't break the layout

PR submission checklist:

I have considered adding unit tests where possible.
I have considered adding accessibility improvements for my changes.
I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

peril-wordpress-mobile · 2021-02-04T16:32:53Z

You can trigger an installable build for these changes by visiting CircleCI here.

peril-wordpress-mobile · 2021-02-04T16:47:31Z

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

leandroalonso · 2021-02-04T16:49:28Z

WordPress/Classes/ViewRelated/Activity/BaseActivityListViewController.swift

+                                          comment: "Title displayed in the Restore Site alert, should match Calypso")
            let rewindDate = viewModel.mediumDateFormatterWithTime.string(from: activity.published)
-            let messageFormat = NSLocalizedString("Are you sure you want to rewind your site back to %@?\nThis will remove all content and options created or changed since then.",
+            let messageFormat = NSLocalizedString("Are you sure you want to restore your site back to %@?\nAnything you changed since then will be lost..",


Two points in the end:

Suggested change

let messageFormat = NSLocalizedString("Are you sure you want to restore your site back to %@?\nAnything you changed since then will be lost..",

let messageFormat = NSLocalizedString("Are you sure you want to restore your site back to %@?\nAnything you changed since then will be lost.",

leandroalonso · 2021-02-04T16:56:39Z

WordPress/Classes/ViewRelated/Jetpack/Jetpack Scan/View Models/JetpackScanStatusViewModel.swift

        static let hasThreatsTitle = NSLocalizedString("Your site may be at risk", comment: "Title for label when there are threats on the users site")
-        static let hasThreatsDescriptionFormat = NSLocalizedString("Jetpack Scan found %1$d potential threats on %2$@. Please review each threat and take action.", comment: "Description for a label when there are threats on the site, displays the number of threats, and the site's title")
-        static let hasSingleThreatDescriptionFormat = NSLocalizedString("Jetpack Scan found 1 potential threat on %1$@. Please review each threat and take action.", comment: "Description for a label when there is a single threat on the site, displays the site's title")
+        static let hasThreatsDescriptionFormat = NSLocalizedString("Jetpack Scan found %1$d potential threats with %2$@. Please review them below and take action or tap the fix all button.. We are here to help if you need us.", comment: "Description for a label when there are threats on the site, displays the number of threats, and the site's title")


Suggested change

static let hasThreatsDescriptionFormat = NSLocalizedString("Jetpack Scan found %1$d potential threats with %2$@. Please review them below and take action or tap the fix all button.. We are here to help if you need us.", comment: "Description for a label when there are threats on the site, displays the number of threats, and the site's title")

static let hasThreatsDescriptionFormat = NSLocalizedString("Jetpack Scan found %1$d potential threats with %2$@. Please review them below and take action or tap the fix all button. We are here to help if you need us.", comment: "Description for a label when there are threats on the site, displays the number of threats, and the site's title")

leandroalonso · 2021-02-04T16:56:55Z

WordPress/Classes/ViewRelated/Jetpack/Jetpack Scan/View Models/JetpackScanStatusViewModel.swift

-        static let hasThreatsDescriptionFormat = NSLocalizedString("Jetpack Scan found %1$d potential threats on %2$@. Please review each threat and take action.", comment: "Description for a label when there are threats on the site, displays the number of threats, and the site's title")
-        static let hasSingleThreatDescriptionFormat = NSLocalizedString("Jetpack Scan found 1 potential threat on %1$@. Please review each threat and take action.", comment: "Description for a label when there is a single threat on the site, displays the site's title")
+        static let hasThreatsDescriptionFormat = NSLocalizedString("Jetpack Scan found %1$d potential threats with %2$@. Please review them below and take action or tap the fix all button.. We are here to help if you need us.", comment: "Description for a label when there are threats on the site, displays the number of threats, and the site's title")
+        static let hasSingleThreatDescriptionFormat = NSLocalizedString("Jetpack Scan found 1 potential threat with %1$@. Please review them below and take action or tap the fix all button.. We are here to help if you need us.", comment: "Description for a label when there is a single threat on the site, displays the site's title")


Suggested change

static let hasSingleThreatDescriptionFormat = NSLocalizedString("Jetpack Scan found 1 potential threat with %1$@. Please review them below and take action or tap the fix all button.. We are here to help if you need us.", comment: "Description for a label when there is a single threat on the site, displays the site's title")

static let hasSingleThreatDescriptionFormat = NSLocalizedString("Jetpack Scan found 1 potential threat with %1$@. Please review them below and take action or tap the fix all button. We are here to help if you need us.", comment: "Description for a label when there is a single threat on the site, displays the site's title")

leandroalonso · 2021-02-04T16:57:28Z

WordPress/Classes/ViewRelated/Jetpack/Jetpack Scan/View Models/JetpackScanStatusViewModel.swift

-        static let noThreatsTitle = NSLocalizedString("Don’t worry about a thing", comment: "Title for label when there are no threats on the users site")
-        static let noThreatsDescriptionFormat = NSLocalizedString("The last Jetpack scan ran %1$@ and everything looked great.\n\nRun a manual scan now or wait for Jetpack to scan your site later today.", comment: "Description for label when there are no threats on a users site and how long ago the scan ran")
-        static let noThreatsDescription = NSLocalizedString("The last Jetpack scan completed and everything looked great.\n\nRun a manual scan now or wait for Jetpack to scan your site later today.", comment: "Description that informs for label when there are no threats on a users site")
+        static let noThreatsTitle = NSLocalizedString("Risks Removed", comment: "Title for label when there are no threats on the users site")


This looks odd to me. What if there was never a threat/risk there? Can we say we removed something?

@osullivanchris JFYI: I was talking to @emilylaguna and we decide to revert this one. "Risks Removed" sounds very vague and it might be misleading: perhaps no risks were there at all.

Can you double-check with the editorial team? Once we have the new string we can update it, for now, we'll move on keeping the previous one.

@leandroalonso Hey its hard for me to follow the code here sorry! Can you tell me what string we're talking about and what the before and after was? Thanks!

@osullivanchris Sorry he's talking about the change from Don’t worry about a thing to Risks Removed

@emilylaguna thanks for clarifying! Yes I think I agree. I would only have this copy right after risks are removed. It sounds like we cannot be certain of that, so the more generic 'Don't worry about a thing' is ok for now. I still think we can improve that string to be less fluffy, but at least its not misleading.

Emily Laguna added 4 commits February 4, 2021 11:05

Update copy on the Scan status view

3f2048b

Replace OK, notify me with approved copy

8e16040

Update backup/restore failed copy

6155d0f

Update scan status copy

cdee6fa

emilylaguna added [Type] Task Jetpack Mobile labels Feb 4, 2021

emilylaguna added this to the 16.7 milestone Feb 4, 2021

emilylaguna requested review from leandroalonso and momo-ozawa February 4, 2021 16:32

emilylaguna self-assigned this Feb 4, 2021

leandroalonso reviewed Feb 4, 2021

View reviewed changes

Emily Laguna added 2 commits February 4, 2021 12:00

Revert "Risks Removed" to "Don’t worry about a thing"

3f4c260

Remove double periods from the scan copy

fa7fe87

leandroalonso approved these changes Feb 4, 2021

View reviewed changes

emilylaguna merged commit 7fb053a into develop Feb 4, 2021

emilylaguna deleted the task/15741-jetpack-editorial-update branch February 4, 2021 22:29

ashiagr mentioned this pull request Feb 8, 2021

Jetpack Scan: Apply copy improvements wordpress-mobile/WordPress-Android#13990

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Jetpack Section: Update copy with editorial text#15790

Jetpack Section: Update copy with editorial text#15790
emilylaguna merged 6 commits intodevelopfrom
task/15741-jetpack-editorial-update

emilylaguna commented Feb 4, 2021

Uh oh!

peril-wordpress-mobile bot commented Feb 4, 2021 •

edited

Loading

Uh oh!

peril-wordpress-mobile bot commented Feb 4, 2021 •

edited

Loading

Uh oh!

leandroalonso Feb 4, 2021

Uh oh!

leandroalonso Feb 4, 2021

Uh oh!

leandroalonso Feb 4, 2021

Uh oh!

leandroalonso Feb 4, 2021

Uh oh!

leandroalonso Feb 4, 2021

Uh oh!

osullivanchris Feb 5, 2021

Uh oh!

emilylaguna Feb 5, 2021

Uh oh!

osullivanchris Feb 5, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	let messageFormat = NSLocalizedString("Are you sure you want to restore your site back to %@?\nAnything you changed since then will be lost..",
	let messageFormat = NSLocalizedString("Are you sure you want to restore your site back to %@?\nAnything you changed since then will be lost.",

	static let hasThreatsDescriptionFormat = NSLocalizedString("Jetpack Scan found %1$d potential threats with %2$@. Please review them below and take action or tap the fix all button.. We are here to help if you need us.", comment: "Description for a label when there are threats on the site, displays the number of threats, and the site's title")
	static let hasThreatsDescriptionFormat = NSLocalizedString("Jetpack Scan found %1$d potential threats with %2$@. Please review them below and take action or tap the fix all button. We are here to help if you need us.", comment: "Description for a label when there are threats on the site, displays the number of threats, and the site's title")

	static let hasSingleThreatDescriptionFormat = NSLocalizedString("Jetpack Scan found 1 potential threat with %1$@. Please review them below and take action or tap the fix all button.. We are here to help if you need us.", comment: "Description for a label when there is a single threat on the site, displays the site's title")
	static let hasSingleThreatDescriptionFormat = NSLocalizedString("Jetpack Scan found 1 potential threat with %1$@. Please review them below and take action or tap the fix all button. We are here to help if you need us.", comment: "Description for a label when there is a single threat on the site, displays the site's title")

Conversation

emilylaguna commented Feb 4, 2021

To test:

PR submission checklist:

Uh oh!

peril-wordpress-mobile bot commented Feb 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

peril-wordpress-mobile bot commented Feb 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

peril-wordpress-mobile bot commented Feb 4, 2021 •

edited

Loading

peril-wordpress-mobile bot commented Feb 4, 2021 •

edited

Loading