Conversation
…o table now uses normalized URL as primary key
…ss-Android into feature/reader-blog-detail
* Blogs are now followed via their domain rather than via encoded full url * Follow status is now updated for all posts after a blog is followed/unfollowed
…ss-Android into feature/reader-blog-detail
…structor in ReaderPostAdapter
…rom blog detail if device rotated while blog detail showing * Merge branch 'develop' of https://github.com/wordpress-mobile/WordPress-Android into feature/reader-blog-detail
…ss-Android into feature/reader-blog-detail
…ss-Android into feature/reader-blog-detail Conflicts: src/org/wordpress/android/ui/reader/ReaderActivity.java src/org/wordpress/android/ui/reader/ReaderPostListFragment.java
…ctionBar on post detail
…ing part of the first post
…mages too large are requested
…ss-Android into feature/reader-discovery Conflicts: src/org/wordpress/android/ui/reader/adapters/ReaderActionBarTagAdapter.java src/org/wordpress/android/ui/reader/adapters/ReaderCommentAdapter.java src/org/wordpress/android/ui/reader/adapters/ReaderPostAdapter.java src/org/wordpress/android/ui/reader/adapters/ReaderTagAdapter.java
Contributor
|
How about using |
…same style as the post excerpt text
…ith 16dp margin on the left/right)
…ss-Android into feature/reader-discovery
Contributor
|
It's looking awesome, I say |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds some new features to the Reader and fixes some longstanding problems.
Blog Preview
Displays posts in a specific blog, with info about the blog (name, description, follower count) and an mshot of the blog above the posts. To display it:
Note that blog preview only works for wp blogs - it's disabled for feeds (see caveat below).
Tag Preview
Posts in the reader post list now show the "primary" tag for each post when available. Tapping this displays all public posts with the tag and enables easily following it.
Redesigned Tag Activity
ReaderTagActivity has been renamed to ReaderSubsActivity and significantly redesigned.
Note that followed blogs does not show feeds you follow (see caveat below).
Backfill
In the past if you synced the reader then don't sync again for some time, with a popular tag there would often be posts missing between the posts previously retrieved and the posts just retrieved.
This PR resolves this problem to a certain degree by detecting when missing posts may exist and "backfills" them. Note that to avoid excessive bandwidth/battery consumption, there is a limit to how many posts will be backfilled.
Caveat
You may encounter problems related to following/unfollowing feeds while testing this PR. These problems are due to limitations in our API and have existed for a while, but may be more obvious now. I'm working to resolve them, and once they're resolved I'll submit a new PR with the fixes.
Issues fixed in this PR: