You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

You can test the changes on this Pull Request by downloading the APK here.

Looks good @renanferrari 👍

This PR simply updates onResume(site: SiteModel) to onResume(site: SiteModel?) as it seems to have fixed the issue, but I wonder if we shouldn't do the same for the other functions in that class that also receive a SiteModel? (cc @aforcier as I don't have much context on this right now)

Yeah let's update them all to be consistent.

Also I just realized this is quite a serious issue - it's going to cause a crash on startup for siteless WordPress.com users. The issue is in 15.6, which just went to the beta channel - I believe we need to change this PR to target release/15.6 and release a 15.6-rc-2, is that correct @oguzkocer ?

Thanks for taking care of it @renanferrari and reviewing it @aforcier!

@aforcier Yes, if it's a serious issue, it'd be better to target release/15.6. I can release a new version on Thursday with other possible fixes.

This may actually be worth a fix on its own, I'll see if anything else is being worked on and potentially release the new beta early.

Thanks for bringing up a fix for this @renanferrari ! 🙇 Just checked this PR as the issue has been reported once more elsewhere 👍

but I wonder if we shouldn't do the same for the other functions in that class that also receive a SiteModel

Just wanted to add to this, hasFullAccessToContent() in SiteUtils (calls for which were what that commit mostly did) accepts the site parameter being null so with this suggested change / question of yours on other functions I believe the behavior which was changed unintentionally would be restored then 👍

I have merged the changes from #12794 and updated the base branch to release/15.6. Ready for review.