Make SiteModel params nullable on WPMainActivity VM event handler methods#12794
Merged
renanferrari merged 1 commit intofix/login-connected-testsfrom Aug 25, 2020
Merged
Conversation
…to comply with previous behavior
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
|
You can test the changes on this Pull Request by downloading the APK here. |
renanferrari
approved these changes
Aug 25, 2020
Contributor
renanferrari
left a comment
There was a problem hiding this comment.
Thanks for handling this, @mzorz! I have tested the changes and can confirm they work well. LGTM!
3 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on top of #12783
As detected by @renanferrari (also reported by @ashiagr) and expressed in #12783, this commit in #12728 unintentionally introduced a behavior change that enforced
SiteModelto be non-null even when having an uninitialized selectedSite is a temporarily possible state.As suggested in #12783 and agreed there, I checked all of the places where
hasFullAccessToContent()was being called previous to that change to verifysiteis not enforced as non-null, and made the changes accordingly.Note: pinging people involved but only 1 approval needed. @ashiagr if you can give it a test, since you could reproduce easily? 🙏
To test:
PR submission checklist:
RELEASE-NOTES.txtif necessary.