Merge 15.6 code freeze to develop#12780
Merged
loremattei merged 10 commits intodevelopfrom Aug 24, 2020
Merged
Conversation
This reverts commit e9bad18.
…d-logging-with-tracking-2 Enable encrypted logging and add tracking
Generated by 🚫 dangerJS |
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
|
You can test the changes on this Pull Request by downloading the APK here. |
loremattei
approved these changes
Aug 24, 2020
Contributor
loremattei
left a comment
There was a problem hiding this comment.
I double checked the strings from WPStories and everything looks fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@loremattei There was an issue you mentioned with
translatable=falsefor strings we import from other libraries. I checked the new gutenberg strings and it doesn't look like they have this property, so I assume we are good, but could you double check it to be sure?