Enable encrypted logging and add tracking#12779
Merged
malinajirka merged 3 commits intorelease/15.6from Aug 24, 2020
Merged
Conversation
This reverts commit e9bad18.
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
|
You can test the changes on this Pull Request by downloading the APK here. |
malinajirka
reviewed
Aug 24, 2020
Contributor
malinajirka
left a comment
There was a problem hiding this comment.
Thanks @oguzkocer! I'm going to test the changes now. Just dropping this comment to speed up the process in case it's actually a bug.
| is EncryptedLogFailedToUpload -> { | ||
| AppLog.e(T.MAIN, "Encrypted log with uuid: ${event.uuid} failed to upload with error: ${event.error}") | ||
| // Only track final errors | ||
| if (event.willRetry) { |
Contributor
There was a problem hiding this comment.
Just to double check -> shouldn't this be !event.willRetry?
If it's correct the way it is now, I feel like the comment might be a bit confusing.
Contributor
Author
There was a problem hiding this comment.
Thanks for catching that @malinajirka! Fixed in 574bbae.
malinajirka
approved these changes
Aug 24, 2020
Contributor
malinajirka
left a comment
There was a problem hiding this comment.
Thanks @oguzkocer! Works as expected ;)!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR re-enables encrypted logging and adds tracking. 738a934 is the revert commit, so it may be skipped during review, so the only code to review is 8a976ae.
To test:
PR submission checklist:
RELEASE-NOTES.txtif necessary.