Conversation
|
You can test the changes on this Pull Request by downloading the APK here. |
ca80f7d to
d52d7b7
Compare
|
Assigning this to @woocommerce/owl-team since this is a dependancy for screenshot creation and I'm not sure how to test it. |
mokagio
left a comment
There was a problem hiding this comment.
To test this, we would have to run the screenshot tests.
I remember @pachlava did some work on them recently, but I don't recall whether they run fine already or not, including the code paths that would generate screenshots.
In this case, though, I think it's fine to merge this version bump and trust the Fastlane maintainers. The PR for 2.1.0 shows that most of the work is cleanups and removed deprecations. 2.1.1 is a service release to actually deploy artifacts to Maven, from the looks of it.
I say let's merge it and deal with any issues whenever we'll need to update the screenshots again. By then, there might be a new tool version out anyway.
|
I'll rebase it to check transitive dependencies changes (#5420) and merge as suggested. Thanks @mokagio ! @dependabot rebase |
d52d7b7 to
71e0863
Compare
|
@dependabot rebase |
Bumps [screengrab](https://github.com/fastlane/fastlane) from 2.0.0 to 2.1.1. - [Release notes](https://github.com/fastlane/fastlane/releases) - [Commits](fastlane/fastlane@2.0.0...2.1.1) --- updated-dependencies: - dependency-name: tools.fastlane:screengrab dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
71e0863 to
81bab6e
Compare
Bumps screengrab from 2.0.0 to 2.1.1.
Release notes
Sourced from screengrab's releases.
... (truncated)
Commits
f46e95cVersion bump to 2.1.1 (#7572)1fc7876Fix typo which causes a crash (#7569)0edd4a0Remove xcode-install dependendy from fastlane (#7554)a5c5e7eVersion bump to 2.1.0 (#7555)b1800cfNot all specs are enabled since the move to monogem (#7559)8b4565cAvoid loading and showing the Snapfile loading twice (#7497)6ec59d6Update README.md (#7385)21af59cFix not showing the lane list and selection when not passing any arguments (#...acdd458Add "--fail-on-errors" support to Danger action (#7487)eb3df49Updated docs description for pilot/testflight action (#7550)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)