Skip to content

[spaceship] fix error "can't modify frozen String"#16403

Merged
janpio merged 1 commit intofastlane:masterfrom
bill2004158:fix-16055
May 2, 2020
Merged

[spaceship] fix error "can't modify frozen String"#16403
janpio merged 1 commit intofastlane:masterfrom
bill2004158:fix-16055

Conversation

@bill2004158
Copy link
Copy Markdown
Contributor

@bill2004158 bill2004158 commented Apr 30, 2020

closes #16055

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@bill2004158
Copy link
Copy Markdown
Contributor Author

@googlebot I signed it!

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@janpio janpio changed the title fix error: can't modify frozen String [spaceship] fix error: can't modify frozen String May 2, 2020
@janpio janpio changed the title [spaceship] fix error: can't modify frozen String [spaceship] fix error "can't modify frozen String" May 2, 2020
@janpio janpio merged commit 97eaa30 into fastlane:master May 2, 2020
@fastlane-bot
Copy link
Copy Markdown

Hey @bill2004158 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

Copy link
Copy Markdown

@fastlane-bot fastlane-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations! 🎉 This was released as part of fastlane 2.147.0 🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

can't modify frozen String: "true" for enterprise builds

4 participants