[action][danger] Add fail-if-no-pr flag to Danger action#18657
Merged
joshdholtz merged 3 commits intofastlane:masterfrom May 14, 2021
Merged
[action][danger] Add fail-if-no-pr flag to Danger action#18657joshdholtz merged 3 commits intofastlane:masterfrom
joshdholtz merged 3 commits intofastlane:masterfrom
Conversation
ainame
approved these changes
May 13, 2021
| FastlaneCore::ConfigItem.new(key: :fail_if_no_pr, | ||
| env_name: "FL_DANGER_FAIL_IF_NO_PR", | ||
| description: "Fail Danger execution if no PR is found", | ||
| type: Boolean, |
joshdholtz
requested changes
May 13, 2021
Member
joshdholtz
left a comment
There was a problem hiding this comment.
Some small change otherwise 💯
| env_name: "FL_DANGER_FAIL_IF_NO_PR", | ||
| description: "Fail Danger execution if no PR is found", | ||
| type: Boolean, | ||
| optional: true, |
Member
There was a problem hiding this comment.
Optional can be removed if there is a default_value for a type: Boolean 😊
joshdholtz
reviewed
May 14, 2021
Member
joshdholtz
left a comment
There was a problem hiding this comment.
Perfect! Thanks for adding this ❤️
joshdholtz
approved these changes
May 14, 2021
fastlane-bot
left a comment
There was a problem hiding this comment.
Congratulations! 🎉 This was released as part of fastlane 2.183.0 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
bundle exec rspecfrom the root directory to see all new and existing tests passbundle exec rubocop -ato ensure the code style is validMotivation and Context
This PR adds the missing
fail-if-no-prflag of Danger action that was missing from the config.Description
Added the corresponding
ConfigItemand append it to the command in the Danger call.Testing Steps
fail-if-no-prflag is added when configured like so.