Refund by items: Max quantity, amount dialog, separate list LiveData - Step 5#1633
Merged
anitaa1990 merged 26 commits intofeature/refund-by-items-masterfrom Dec 13, 2019
Merged
Conversation
… to exceed the maximum
# Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/widgets/NumberPickerDialog.kt
…tom-amount-dialog
This reverts commit e9ed912.
Generated by 🚫 dangerJS |
|
You can test the changes on this Pull Request by downloading the APK here. |
# Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/ui/refunds/IssueRefundViewModel.kt # WooCommerce/src/main/kotlin/com/woocommerce/android/ui/refunds/RefundByItemsFragment.kt # WooCommerce/src/main/res/layout/fragment_refund_by_items.xml
Contributor
Author
|
Nice catch! The list used to be preserved with the rest of the state but it was extracted. I added a logic that reloads the list and saves the selected quantities so it should be fixed now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR introduces 3 main features:
Note: The refund flow is not working in this PR yet. It's completed in #1635.
To test:
Max quantity limit
Custom products refund amount
Select all button
Note: #1629 should be merged before this PR.