Refund by items: Rounding errors - Step 4#1629
Merged
anitaa1990 merged 10 commits intofeature/refund-by-items-masterfrom Dec 12, 2019
Merged
Refund by items: Rounding errors - Step 4#1629anitaa1990 merged 10 commits intofeature/refund-by-items-masterfrom
anitaa1990 merged 10 commits intofeature/refund-by-items-masterfrom
Conversation
|
You can test the changes on this Pull Request by downloading the APK here. |
anitaa1990
approved these changes
Dec 12, 2019
Contributor
anitaa1990
left a comment
There was a problem hiding this comment.
Looks good! Just left one non blocking comment in the PR. 
Comment on lines
+5
to
+7
| fun min(a: BigDecimal, b: BigDecimal): BigDecimal = if (a < b) a else b | ||
|
|
||
| fun max(a: BigDecimal, b: BigDecimal): BigDecimal = if (a > b) a else b |
Contributor
There was a problem hiding this comment.
np: I'm not seeing this used anywhere in the app? Is it used in another PR? If not, can we remove it?
Contributor
Author
There was a problem hiding this comment.
Yeah, it's used in the next PR. Thanks for checking!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're using
BigDecimals to minimize the rounding error during calculations. Recently I noticed that theIssue refundbutton is being shown even though there is no more money to be refunded (total - refund total was supposed to be 0). It turned out that there was rounding error already present that came from the API. This PR makes sure the errors are removed during model creation.Note: #1623 must be merged before this PR.