Refund by items: Full refund flow - Step 6 by 0nko · Pull Request #1635 · woocommerce/woocommerce-android

0nko · 2019-12-04T10:44:08Z

This PR brings the complete refund-by-items flow.

To test:

Create an order with multiple items
Go to order detail and issue a refund
Select a subset of items for refund
Verify the subtotal, total and tax calculations are correct
Finish the partial refund and notice a new refund item appears in the order detail
On the web, verify that the number of refunded items in order detail matches the recent refund quantities
Go back to the app and create a full refund by selecting all items
Complete the refund and notice a new refund item appears in the order detail
Verify the Issue refund button is not visible anymore and the order status is now Refunded
Verify that the refund tab changes, number picker, select all button taps are all tracked

# Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/ui/orders/AddOrderShipmentTrackingFragment.kt # WooCommerce/src/main/kotlin/com/woocommerce/android/ui/refunds/IssueRefundViewModel.kt

…plicate emails

peril-woocommerce · 2019-12-04T10:49:03Z

You can test the changes on this Pull Request by downloading the APK here.

# Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/ui/refunds/IssueRefundViewModel.kt # WooCommerce/src/main/kotlin/com/woocommerce/android/ui/refunds/RefundByItemsFragment.kt # WooCommerce/src/main/res/layout/refund_by_items_products.xml # build.gradle

# Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/ui/refunds/IssueRefundViewModel.kt

…ms-flow

anitaa1990

Changes look good @0nko!! Just left a couple of comments in the code. There were some minor issues faced when testing that I have listed below:

If we click on the back button and go to the Order detail screen, when the refund is being processed, the Order detail is not refreshed when the refresh is completed and there is no snackbar to indicate the the refund was successfully processed.

I refunded all the items from the product list and there was still $4.99 left (this was due to shipping). But I am not able to see the Issue refund button anymore. But when I click on the Home button and open the app again, the Issue Refund button is displayed. Note that I had Do not keep activities enabled on my device.

(LEFT: Before clicking on Home button after successful refund)
(RIGHT: After opening the app again)
.

anitaa1990 · 2019-12-13T09:33:22Z

WooCommerce/src/main/kotlin/com/woocommerce/android/analytics/AnalyticsTracker.kt

+        CREATE_ORDER_REFUND_TAB_CHANGED,
+        CREATE_ORDER_REFUND_SELECT_ALL_ITEMS_BUTTON_TAPPED,
+        CREATE_ORDER_REFUND_ITEM_QUANTITY_DIALOG_OPENED,
+        CREATE_ORDER_REFUND_PRODUCT_AMOUNT_DIALOG_OPENED,


np: I didn't find any of these events in the event streadsheet. Just mentioning it here so it doesn't get missed, we would need to add all new events to the event streadsheet and validate/register them :)

I've added the events to the spreadsheet. Thanks for checking!

anitaa1990 · 2019-12-13T09:34:35Z

WooCommerce/src/main/res/layout/refund_by_items_products.xml

+        app:layout_constraintTop_toTopOf="@id/issueRefund_lblProductsTotal"
+        tools:text="$1.00"/>
+
+<!--    <androidx.appcompat.widget.AppCompatButton-->


np: Can we add a some explanation here on why this is commented out so we don't forget and delete it by accident in the future?

anitaa1990 · 2019-12-13T09:35:37Z

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/refunds/RefundByItemsFragment.kt

-        issueRefund_productsTotal.setOnClickListener {
-            viewModel.onProductRefundAmountTapped()
-        }
+        // will be used in the future


np: same comment here. Would it be possible to explain why this is commented out so we don't accidentally delete it in the future?

This reverts commit d599bbf.

wpmobilebot · 2019-12-13T12:23:02Z

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/refunds/RefundByItemsFragment.kt

                issueRefund_selectButton.text = it
            }
-            // temporarily hidden
+


Reporter: Checkstyle
Rule: no-trailing-spaces
Severity: ERROR
File: /home/circleci/project/WooCommerce/src/main/kotlin/com/woocommerce/android/ui/refunds/RefundByItemsFragment.kt L98
Trailing space(s)

0nko · 2019-12-13T12:36:29Z

Thanks for the review, @anitaa1990!

If we click on the back button and go to the Order detail screen, when the refund is being processed, the Order detail is not refreshed when the refresh is completed and there is no snackbar to indicate the the refund was successfully processed.

I've disabled the button during the refund process. I know it's not an ideal UX but it'd complicate things a lot to keep the job running in the background on a global scope. Plus I don't think it's gonna happen too often.

I refunded all the items from the product list and there was still $4.99 left (this was due to shipping). But I am not able to see the Issue refund button anymore. But when I click on the Home button and open the app again, the Issue Refund button is displayed. Note that I had Do not keep activities enabled on my device.

This one's weird. I think it has something to do with the rounding errors. I've added rounding fix for the Refund model, which was missing.

As for the shipping refund, this is not supported by the API at the moment (only using refund by amount, which screws up the reports). So once the full product amount is refunded, refunding is not allowed anymore. This will be fixed once the API supports refund shipping properly.

peril-woocommerce · 2019-12-13T12:38:42Z

	Messages
📖	This PR contains changes to Tracks-related logic. Please ensure the following are completed: PR Author The PR must be assigned the Tracks label PR Reviewer The tracks events must be validated in the Tracks system. Verify the internal tracks spreadsheet has also been updated.

Generated by 🚫 dangerJS

anitaa1990

Looks good! Thanks for the explanation! So the way I understand it, we cannot fully refund an order now, correct? Because everytime I try to refund the full order by selecting Select All, there is still some amount left, which is because of shipping. And since we have temporarily removed the option to refund via amount, the user will not be able to refund the order and the status will remain Processing. Is that correct?

0nko · 2019-12-13T15:47:41Z

That's right. Unfortunately.

0nko added 11 commits November 29, 2019 09:54

Fix the refund total calculation

d745551

Move the 2nd snackbar after the refund is confirmed

dcce301

Update the FluxC reference to the latest refund-by-items changes

3066dd4

Fix the refund total calculation and send the items for refund

a572626

Fix the refund by items endpoint data model & update FluxC reference

49ba6c9

Optimize imports

c21a847

Add newline to end of file

dead627

Merge branch '0nko/custom-amount-dialog' into 0nko/refund-by-items-flow

f464958

# Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/ui/orders/AddOrderShipmentTrackingFragment.kt # WooCommerce/src/main/kotlin/com/woocommerce/android/ui/refunds/IssueRefundViewModel.kt

Replace the product refunds total button with a text view

6fda42d

Add new refund by items analytics tracking

00ccbfe

Make the refund note private so that the customer does not receive du…

49afa38

…plicate emails

0nko added status: do not merge Dependent on another PR, ready for review but not ready for merge. feature: refunds Related to order refunds. labels Dec 4, 2019

0nko added this to the 3.3 milestone Dec 4, 2019

0nko mentioned this pull request Dec 4, 2019

Refund by items updates wordpress-mobile/WordPress-FluxC-Android#1436

Merged

Fix the broken unit tests

b773e37

0nko mentioned this pull request Dec 12, 2019

Refund by items: Max quantity, amount dialog, separate list LiveData - Step 5 #1633

Merged

0nko added 3 commits December 12, 2019 11:53

Merge branch '0nko/custom-amount-dialog' into 0nko/refund-by-items-flow

ca521ce

# Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/ui/refunds/IssueRefundViewModel.kt

Merge branch 'feature/refund-by-items-master' into 0nko/refund-by-ite…

ad8f7ca

…ms-flow

0nko removed the status: do not merge Dependent on another PR, ready for review but not ready for merge. label Dec 13, 2019

0nko changed the base branch from 0nko/custom-amount-dialog to feature/refund-by-items-master December 13, 2019 09:13

0nko requested review from AmandaRiu, anitaa1990 and nbradbury December 13, 2019 09:13

anitaa1990 self-assigned this Dec 13, 2019

anitaa1990 reviewed Dec 13, 2019

View reviewed changes

0nko added 2 commits December 13, 2019 12:40

Increase the refresh delay to 2s

d599bbf

Revert "Increase the refresh delay to 2s"

100c15e

This reverts commit d599bbf.

0nko added 3 commits December 13, 2019 13:14

Disable the back button action when refund in progress

d915a72

Add description for commented out code

ab64ac1

Round the error for refund model properties

8d43203

wpmobilebot reviewed Dec 13, 2019

View reviewed changes

Fix ktlint

d3ce8e0

0nko requested a review from anitaa1990 December 13, 2019 12:38

anitaa1990 approved these changes Dec 13, 2019

View reviewed changes

anitaa1990 merged commit 21b6028 into feature/refund-by-items-master Dec 13, 2019

shiki mentioned this pull request Sep 16, 2020

[Issue Refunds] Add Tracking for Refunding by Items woocommerce/woocommerce-ios#2793

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refund by items: Full refund flow - Step 6#1635

Refund by items: Full refund flow - Step 6#1635
anitaa1990 merged 21 commits intofeature/refund-by-items-masterfrom
0nko/refund-by-items-flow

0nko commented Dec 4, 2019

Uh oh!

peril-woocommerce bot commented Dec 4, 2019 •

edited

Loading

Uh oh!

anitaa1990 left a comment

Uh oh!

anitaa1990 Dec 13, 2019

Uh oh!

0nko Dec 13, 2019

Uh oh!

anitaa1990 Dec 13, 2019

Uh oh!

anitaa1990 Dec 13, 2019

Uh oh!

wpmobilebot Dec 13, 2019

Uh oh!

0nko commented Dec 13, 2019

Uh oh!

peril-woocommerce bot commented Dec 13, 2019

Uh oh!

anitaa1990 left a comment

Uh oh!

0nko commented Dec 13, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

0nko commented Dec 4, 2019

Uh oh!

peril-woocommerce bot commented Dec 4, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

anitaa1990 left a comment

Choose a reason for hiding this comment

Uh oh!

anitaa1990 Dec 13, 2019

Choose a reason for hiding this comment

Uh oh!

0nko Dec 13, 2019

Choose a reason for hiding this comment

Uh oh!

anitaa1990 Dec 13, 2019

Choose a reason for hiding this comment

Uh oh!

anitaa1990 Dec 13, 2019

Choose a reason for hiding this comment

Uh oh!

wpmobilebot Dec 13, 2019

Choose a reason for hiding this comment

Uh oh!

0nko commented Dec 13, 2019

Uh oh!

peril-woocommerce bot commented Dec 13, 2019

Uh oh!

anitaa1990 left a comment

Choose a reason for hiding this comment

Uh oh!

0nko commented Dec 13, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

peril-woocommerce bot commented Dec 4, 2019 •

edited

Loading