Avoid adding redundant aria-current="false" to sidebar entries#3658
Merged
Avoid adding redundant aria-current="false" to sidebar entries#3658
aria-current="false" to sidebar entries#3658Conversation
🦋 Changeset detectedLatest commit: 8020758 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for astro-starlight ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
size-limit report 📦
|
HiDeoo
approved these changes
Jan 16, 2026
Member
HiDeoo
left a comment
There was a problem hiding this comment.
Damn, we missed one case, great catch.
The changes look great and I also confirmed the fix by comparing the live and deploy versions 🚀
Merged
dadezzz
pushed a commit
to dadezzz/ice-notes
that referenced
this pull request
Jan 25, 2026
This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [@astrojs/starlight](https://starlight.astro.build) ([source](https://github.com/withastro/starlight/tree/HEAD/packages/starlight)) | [`0.37.3` → `0.37.4`](https://renovatebot.com/diffs/npm/@astrojs%2fstarlight/0.37.3/0.37.4) |  |  | --- ### Release Notes <details> <summary>withastro/starlight (@​astrojs/starlight)</summary> ### [`v0.37.4`](https://github.com/withastro/starlight/blob/HEAD/packages/starlight/CHANGELOG.md#0374) [Compare Source](https://github.com/withastro/starlight/compare/@astrojs/starlight@0.37.3...@astrojs/starlight@0.37.4) ##### Patch Changes - [#​3534](withastro/starlight#3534) [`703fab0`](withastro/starlight@703fab0) Thanks [@​HiDeoo](https://github.com/HiDeoo)! - Fixes support for running builds when `npx` is unavailable. Previously, Starlight would spawn a process to run the Pagefind search indexing binary using `npx`. On platforms where `npx` isn’t available, this could cause issues. Starlight now runs Pagefind using its Node.js API to avoid a separate process. As a side effect, you may notice that logging during builds is now less verbose. - [#​3656](withastro/starlight#3656) [`a0e6368`](withastro/starlight@a0e6368) Thanks [@​delucis](https://github.com/delucis)! - Fixes several edge cases in highlighting the current page heading in Starlight’s table of contents - [#​3663](withastro/starlight#3663) [`00cbf00`](withastro/starlight@00cbf00) Thanks [@​lines-of-codes](https://github.com/lines-of-codes)! - Adds Thai language support - [#​3658](withastro/starlight#3658) [`ac79329`](withastro/starlight@ac79329) Thanks [@​delucis](https://github.com/delucis)! - Avoids adding redundant `aria-current="false"` attributes to sidebar entries - [#​3382](withastro/starlight#3382) [`db295c2`](withastro/starlight@db295c2) Thanks [@​trueberryless](https://github.com/trueberryless)! - Fixes an issue where the mobile table of contents is unable to find the first heading when a page has a tall banner. </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi45Mi40IiwidXBkYXRlZEluVmVyIjoiNDIuOTIuNCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: Renovate Bot <renovate@zarantonello.dev> Co-committed-by: Renovate Bot <renovate@zarantonello.dev>
HiDeoo
added a commit
to HiDeoo/starlight
that referenced
this pull request
Jan 29, 2026
* main: Avoid adding redundant `aria-current="false"` to sidebar entries (withastro#3658) Add link to a new community pluing (withastro#3657) [ci] release (withastro#3654) chore(deps): update actions/setup-node action to v6.2.0 (withastro#3655) Fix: Prevent font-size adjustments on iOS after orientation change (withastro#3648) feat: ✨ add catchintent starlight docs for showcase (withastro#3652)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes handling of a boolean attribute in our sidebar code to avoid adding redundant
aria-current="false"attributes. Before Astro v5, passingfalsetoaria-currentresulted in omitting the attribute in the HTML output. But since v5, this is now stringified to"false"(Astro only omits the attribute for officially boolean attributes in the HTML spec now).