Merged
Conversation
🦋 Changeset detectedLatest commit: 1e79b48 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for astro-starlight ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
commit: |
|
Hello, thanks a lot for the PR, is there a chance this goes into the next version? 😄 |
Member
Yes, planned for v0.38! |
|
Nice, thanks a lot! |
delucis
reviewed
Jan 14, 2026
Member
delucis
left a comment
There was a problem hiding this comment.
Ah, and I missed the failing coverage check. Looks like we should add some testing maybe? The new integrations/pagefind.ts file is showing many lines uncovered in tests.
Co-authored-by: delucis <357379+delucis@users.noreply.github.com>
Merged
dadezzz
pushed a commit
to dadezzz/ice-notes
that referenced
this pull request
Jan 25, 2026
This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [@astrojs/starlight](https://starlight.astro.build) ([source](https://github.com/withastro/starlight/tree/HEAD/packages/starlight)) | [`0.37.3` → `0.37.4`](https://renovatebot.com/diffs/npm/@astrojs%2fstarlight/0.37.3/0.37.4) |  |  | --- ### Release Notes <details> <summary>withastro/starlight (@​astrojs/starlight)</summary> ### [`v0.37.4`](https://github.com/withastro/starlight/blob/HEAD/packages/starlight/CHANGELOG.md#0374) [Compare Source](https://github.com/withastro/starlight/compare/@astrojs/starlight@0.37.3...@astrojs/starlight@0.37.4) ##### Patch Changes - [#​3534](withastro/starlight#3534) [`703fab0`](withastro/starlight@703fab0) Thanks [@​HiDeoo](https://github.com/HiDeoo)! - Fixes support for running builds when `npx` is unavailable. Previously, Starlight would spawn a process to run the Pagefind search indexing binary using `npx`. On platforms where `npx` isn’t available, this could cause issues. Starlight now runs Pagefind using its Node.js API to avoid a separate process. As a side effect, you may notice that logging during builds is now less verbose. - [#​3656](withastro/starlight#3656) [`a0e6368`](withastro/starlight@a0e6368) Thanks [@​delucis](https://github.com/delucis)! - Fixes several edge cases in highlighting the current page heading in Starlight’s table of contents - [#​3663](withastro/starlight#3663) [`00cbf00`](withastro/starlight@00cbf00) Thanks [@​lines-of-codes](https://github.com/lines-of-codes)! - Adds Thai language support - [#​3658](withastro/starlight#3658) [`ac79329`](withastro/starlight@ac79329) Thanks [@​delucis](https://github.com/delucis)! - Avoids adding redundant `aria-current="false"` attributes to sidebar entries - [#​3382](withastro/starlight#3382) [`db295c2`](withastro/starlight@db295c2) Thanks [@​trueberryless](https://github.com/trueberryless)! - Fixes an issue where the mobile table of contents is unable to find the first heading when a page has a tall banner. </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi45Mi40IiwidXBkYXRlZEluVmVyIjoiNDIuOTIuNCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: Renovate Bot <renovate@zarantonello.dev> Co-committed-by: Renovate Bot <renovate@zarantonello.dev>
HiDeoo
added a commit
to HiDeoo/starlight
that referenced
this pull request
Jan 29, 2026
* main: [ci] release (withastro#3659) fix: mobile toc issue with custom banners (withastro#3382) chore(deps): update actions/checkout action to v6.0.2 (withastro#3670) Fix table of contents intersection observer (withastro#3656) chore(deps): update peter-evans/create-pull-request action to v8.1.0 (withastro#3669) Pagefind CLI → Pagefind API (withastro#3534) chore(deps): update changesets/action action to v1.6.0 (withastro#3668) i18n(de): Fix orthographic errors in `getting-started.mdx` and `index.mdx` (withastro#3664) i18n(fr): update `resources/plugins.mdx` (withastro#3665) [ci] format i18n(th): Add Thai translations to Starlight UI (withastro#3663) i18n(de): update resources/plugins.mdx (withastro#3662) i18n(ko): update community plugins (withastro#3661)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors how Pagefind is run after the build process. Instead of using the CLI via
npx, it now uses the Pagefind API directly.Feature-wise, there should be no changes but one aspect which will differ is logging.
We are now directly using a fork of the Starlight ingration logger. I didn't spend too much time on tweaking the logging output so far, but one huge difference is that we don't have access to the same informations when using the API vs CLI which access them using some internal Rust code and that data is not exposed via the API.
Personally, I never found the logging output of the CLI very useful, so I think this is an overall improvement but definitely something worth mentioning and discussing if needed.
Todo