Disable Renovate uses-with for Node.js#3376
Conversation
|
✅ Deploy Preview for astro-starlight ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
delucis
left a comment
There was a problem hiding this comment.
I guess the thinking behind the change is to make the implicit Node versioning behaviour more explicit? i.e. currently if we specify 18, the action will get the latest 18 release, changing across runs. After the Renovate PR, the Node version is pinned to a specific patch and will only change when we merge a Renovate PR.
In principle, I think that’s good, although I agree that a) sometimes we are intentionally using old versions and b) updating for every Node patch is a bit annoying (I can already confirm this from experience with the astro.build repo).
So might be good to accept the PR pinning Node to a specific patch and then disable subsequent updates?
That's also a possibility. That would mean (if everything goes well ^^)
|
|
Sounds like a good experiment 😁 |
| { | ||
| description: 'Disable Node.js version updates with actions/setup-node', | ||
| matchDepNames: ['node'], | ||
| matchDepTypes: ['uses-with'], | ||
| enabled: false, | ||
| }, |
There was a problem hiding this comment.
Noting that our existing github-actions group uses matchManagers: ['github-actions'] to target these specifically, but not sure that’s relevant here.
There was a problem hiding this comment.
The reason I did not add it is to potentially catch similar rules that may in the future have a similar behavior for Node.js versions, e,.g. a similar rule was added for pnpm/action-setup but in this case the data source is npm.
* upstream/main: (139 commits) chore(deps): update actions/checkout action to v5 (withastro#3375) Disable Renovate `uses-with` for Node.js (withastro#3376) i18n(fr): update `resources/plugins` (withastro#3378) chore(deps): update github-actions (withastro#3374) i18n(ko-KR): update `plugins.mdx` (withastro#3377) i18n(de): update `plugins.mdx` (withastro#3367) Add `starlight-github-alerts` plugin to plugin showcase (withastro#3369) i18n(fr): update `resources/plugins.mdx` (withastro#3372) i18n(fr): update `resources/community-content.mdx` (withastro#3371) [ci] format i18n(fr): update `environmental-impact.md` (withastro#3370) [ci] format i18n(de): update `community-content.mdx` (withastro#3366) [ci] format i18n(de): update `environmental-impact.md` (withastro#3365) [ci] format i18n(ko-KR): update `environmental-impact.md` (withastro#3368) Update carbon calculator stats for v4 model (withastro#3364) i18n(ko-KR): update `community-content.mdx` (withastro#3362) i18n(ko-KR): update `plugins.mdx` (withastro#3361) ...
Description
This PR is a follow-up to the
uses-withupdates in #3374 and #3375 and aims to disable Node.js version updates foractions/setup-nodein Renovate.As I mentioned in this comment, this is done for a few reasons:
As usual, I don't think there is a way to test this change without merging it, and not explicitely documented (or I missed it), but hopefully after merging this PR and waiting a bit, Renovate should close the 2 existing PRs I mentioned and should create 2 new ones only containing an update for
actions/checkout(which was bundled in the previous PRs with the Node.js version update).If this works as expected, I'll port this change to Astro Docs.