Skip to content

fix(de): replace translation of "icon" in german language [i18nIgnore]#3060

Merged
delucis merged 2 commits intowithastro:mainfrom
trueberryless:fix-symbols-vs-icons-translation-de
Apr 10, 2025
Merged

fix(de): replace translation of "icon" in german language [i18nIgnore]#3060
delucis merged 2 commits intowithastro:mainfrom
trueberryless:fix-symbols-vs-icons-translation-de

Conversation

@trueberryless
Copy link
Copy Markdown
Contributor

@trueberryless trueberryless commented Apr 7, 2025

Description

  • This PR replaces translations of the English word icon from the German translation Icon to Symbol so it is consistent across all pages. Therefore the i18nIgnore, because this should not mark pages as completed in any way.
  • This is a follow-up PR of i18n(de): change translation of icon #2949 where Chris and I agreed on making the translation consistent the other way around (initially I wanted to replace all Symbol with Icon, but Wikipedia says, Symbol is the generally more acceptable translation of icon
  • I again ask a native speaker to review this PR, maybe @delucis wants to step up again and help out as always 💜 (I think I didn't miss any Icons with my global VS Code search...)

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 7, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 8b9b792

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added i18n Anything to do with internationalization & translation efforts 📚 docs Documentation website changes labels Apr 7, 2025
@netlify
Copy link
Copy Markdown

netlify bot commented Apr 7, 2025 •
edited
Loading

✅ Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit 8b9b792
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/67f7aad05f6df300097cea90
😎 Deploy Preview https://deploy-preview-3060--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Apr 7, 2025 •
edited
Loading

Lunaria Status Overview

🌑 This pull request will not trigger status changes.

Learn more

Lunaria automatically ignores changes on specific PRs by adding a ignored keyword in its title. Found: i18nIgnore.

You can change this by either removing the keyword above from the PR's title, or modifying the ignoreKeywords property in your Lunaria configuration file.

Tracked Files

Note

The notes below indicate what would happen if the pull request is merged when triggering status changes. Since a ignored keyword was found in the PR's title, the status changes indicated below won't be applied.

Locale File Note
de components/cards.mdx Localization changed, will be marked as complete.
de components/icons.mdx Localization changed, will be marked as complete.
de components/tabs.mdx Localization changed, will be marked as complete.
de reference/configuration.mdx Localization changed, will be marked as complete.
de reference/icons.mdx Localization changed, will be marked as complete.
de reference/overrides.md Localization changed, will be marked as complete.
de resources/community-content.mdx Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@trueberryless trueberryless changed the title i18n(de): replace translation of "icon" in german language [i18nIgnore] fix(de): replace translation of "icon" in german language [i18nIgnore] Apr 8, 2025
delucis
delucis reviewed Apr 10, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🙌

Just left one query.

@delucis delucis merged commit 95706cb into withastro:main Apr 10, 2025
15 checks passed
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Apr 10, 2025
@HiDeoo
Merge branch 'main' into hd-feat-cascade-layers
59e6ec0 
* main: (64 commits)
  feat: add Starlight Changelog to community content (withastro#3074)
  i18n(ko-KR): update `themes.mdx` (withastro#3083)
  i18n(de): update `reference/plugins` (withastro#3070)
  i18n(de): update `reference/configuration` (withastro#3069)
  i18n(de): update `guides/customization` (withastro#3067)
  [i18nIgnore] fix(de): make `e.g.` consistent in German translation (withastro#3068)
  [i18nIgnore] fix(de): replace translation of "icon" in german language (withastro#3060)
  feat: add NextJS theme (withastro#3075)
  i18n(ko-KR): update `route-data.mdx` (withastro#3081)
  i18n(ko-KR): update `plugins.md` (withastro#3080)
  [ci] format
  i18n(ko-KR): update `configuration.mdx` (withastro#3078)
  i18n(ko-KR): update `customization.mdx` (withastro#3077)
  i18n(ko-KR): update `overrides.md` (withastro#3079)
  i18n(ko-KR): update `plugins.mdx` (withastro#3082)
  i18n(ko-KR): update `badges.mdx` (withastro#3076)
  i18n(ru): update `reference/route-data.mdx` and `reference/overrides.md` (withastro#3064)
  i18n(fr): update `reference/configuration` (withastro#3053)
  i18n(ru): update `resources/plugins.mdx` (withastro#3062)
  i18n(ru): update `components/badges.mdx` (withastro#3063)
  ...
@trueberryless trueberryless deleted the fix-symbols-vs-icons-translation-de branch June 7, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@delucis delucis delucis left review comments

Assignees

No one assigned

Labels

📚 docs Documentation website changes i18n Anything to do with internationalization & translation efforts

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@trueberryless @astrobot-houston @delucis