Skip to content

[i18nIgnore] docs: Exchange apostrophes in plugins to be smart#3001

Merged
delucis merged 1 commit intowithastro:mainfrom
trueberryless:change-apostrophe-plugin
Mar 21, 2025
Merged

[i18nIgnore] docs: Exchange apostrophes in plugins to be smart#3001
delucis merged 1 commit intowithastro:mainfrom
trueberryless:change-apostrophe-plugin

Conversation

@trueberryless
Copy link
Copy Markdown
Contributor

@trueberryless trueberryless commented Mar 21, 2025

As noticed in #2998 there are some plugins that use ' (straight apostrophe) instead of (’) smart apostrophes.

This is probably unintentional by the author of the PRs adding these plugins and changed to be smart in this PR.

Reference: #2998 (comment)

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 21, 2025

⚠️ No Changeset found

Latest commit: 67365fb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the 📚 docs Documentation website changes label Mar 21, 2025
@netlify
Copy link
Copy Markdown

netlify bot commented Mar 21, 2025 •
edited
Loading

✅ Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit 67365fb
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/67ddc7b104e55b0008d8bab7
😎 Deploy Preview https://deploy-preview-3001--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Mar 21, 2025

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en resources/plugins.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

delucis
delucis approved these changes Mar 21, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning that up! I guess this might not require translation updates for everyone, so I’ll merge with an i18nIgnore keyword.

@delucis delucis changed the title feat(docs): Exchange apostrophes in plugins to be smart [i18nIgnore] docs: Exchange apostrophes in plugins to be smart Mar 21, 2025
@delucis delucis merged commit 6f0c656 into withastro:main Mar 21, 2025
16 checks passed
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Mar 24, 2025
@HiDeoo
Merge branch 'main' into hd-feat-cascade-layers
a5fa55e 
* main:
  i18n(fr): update `reference/plugins.md` (withastro#3011)
  i18n(ko-KR): update `plugins.md` (withastro#3010)
  i18n(de): update `plugins.mdx` (withastro#3009)
  Fix code example in plugin reference (withastro#3005)
  update plugins (withastro#3003)
  [ci] format
  i18n(ko-KR): update `plugins.mdx` (withastro#3002)
  [i18nIgnore] docs: Exchange apostrophes in plugins to be smart (withastro#3001)
  i18n(fr): update `resources/plugins` (withastro#3000)
@trueberryless trueberryless deleted the change-apostrophe-plugin branch April 7, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@delucis delucis delucis approved these changes

Assignees

No one assigned

Labels

📚 docs Documentation website changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@trueberryless @astrobot-houston @delucis