Skip to content

i18n(fr): fix highlighting in reference/plugins.md#2898

Merged
delucis merged 1 commit intowithastro:mainfrom
ArmandPhilippot:i18n/fr-fix-highlighting
Feb 17, 2025
Merged

i18n(fr): fix highlighting in reference/plugins.md#2898
delucis merged 1 commit intowithastro:mainfrom
ArmandPhilippot:i18n/fr-fix-highlighting

Conversation

@ArmandPhilippot
Copy link
Copy Markdown
Member

@ArmandPhilippot ArmandPhilippot commented Feb 17, 2025

Description

Updates the French translation of reference/plugins to fix a code snippet highlighting.

I suggested a fix in #2886 (comment) but I didn't pay attention that we already have en in the string so the highlighting is currently wrong.

Before After
starlight-before starlight-after

I'm not used to Expressive Code so perhaps there is better a way... Looking at the docs it seems we need capture groups. The recommended syntax is /\/(en)\// but Prettier removes the escape characters... Tested locally with the dev server, it also works without!

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Feb 17, 2025

⚠️ No Changeset found

Latest commit: 3872a50

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added i18n Anything to do with internationalization & translation efforts 📚 docs Documentation website changes labels Feb 17, 2025
@netlify
Copy link
Copy Markdown

netlify bot commented Feb 17, 2025 •
edited
Loading

✅ Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit 3872a50
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/67b319adcc69500008d91923
😎 Deploy Preview https://deploy-preview-2898--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Feb 17, 2025

Hello! Thank you for opening your first PR to Starlight! ✨

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any issues you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🤩

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Feb 17, 2025

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
fr reference/plugins.md Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

delucis
delucis approved these changes Feb 17, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch — thank you @ArmandPhilippot!

And can’t believe this is your FIRST Starlight PR 🤯

@delucis delucis merged commit 7af9cb0 into withastro:main Feb 17, 2025
@ArmandPhilippot ArmandPhilippot deleted the i18n/fr-fix-highlighting branch February 17, 2025 12:31
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Feb 19, 2025
@HiDeoo
Merge branch 'main' into hd-feat-cascade-layers
efedb64 
* main: (493 commits)
  i18n(de): update `sidebar.mdx` (withastro#2900)
  Adding all samples for badges in sidebar as example (withastro#2881)
  i18n(fr): fix highlighting in `reference/plugins.md` (withastro#2898)
  i18n(fr): update `reference/plugins` & `guides/i18n` (withastro#2886)
  i18n(fr): update `reference/overrides` & `guides/sidebar` (withastro#2887)
  i18n(fr): add `guides/route-data` and `reference/route-data` (withastro#2884)
  i18n(fr): update `guides/overriding-components` (withastro#2885)
  i18n(fr): update `reference/configuration` (withastro#2888)
  i18n(de): update German translation with withastro#2578 (withastro#2882)
  [ci] format
  i18n(ru): update some translations (withastro#2895)
  i18n(de): update `reference/configuration.mdx` (withastro#2883)
  [ci] format
  i18n(ko-KR): update `configuration.mdx` (withastro#2892)
  i18n(ko-KR): update `overrides.md` (withastro#2893)
  i18n(ko-KR): update `overriding-components.mdx` (withastro#2890)
  i18n(ko-KR): update `i18n.mdx` and `plugins.md` (withastro#2889)
  [ci] format
  i18n(ko-KR): create `guides/route-data.mdx` and `reference/route-data.mdx` (withastro#2896)
  i18n(ko-KR): update `/resources/plugins.mdx` (withastro#2894)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@delucis delucis delucis approved these changes

Assignees

No one assigned

Labels

📚 docs Documentation website changes i18n Anything to do with internationalization & translation efforts

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ArmandPhilippot @astrobot-houston @delucis