i18n(fr): update `reference/plugins` & `guides/i18n` by HiDeoo · Pull Request #2886 · withastro/starlight

HiDeoo · 2025-02-16T00:38:38Z

Description

This PR updates the French version of the reference/plugins & guides/i18n pages with the changes from #2390 and #2578.

changeset-bot · 2025-02-16T00:38:41Z

⚠️ No Changeset found

Latest commit: db70ec7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

netlify · 2025-02-16T00:39:02Z

✅ Deploy Preview for astro-starlight ready!

Name	Link
🔨 Latest commit	`db70ec7`
🔍 Latest deploy log	https://app.netlify.com/sites/astro-starlight/deploys/67b233edecbd8b0008fa2c35
😎 Deploy Preview	https://deploy-preview-2886--astro-starlight.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 99 (🔴 down 1 from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 100 (no change from production) PWA: - View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

astrobot-houston · 2025-02-16T00:39:14Z

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale	File	Note
fr	guides/i18n.mdx	Localization changed, will be marked as complete.
fr	reference/plugins.md	Localization changed, will be marked as complete.

Warnings reference

Icon	Description
🔄️	The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

trueberryless

Very good translations! I really like how you interchanged the en and fr locals at the end of plugin reference to demonstrate it exactly like the English version, but for all the French people ❤️

Left some thoughts about some parts where I - as a non-native - can't conclude whether something was overlooked or intentional.

docs/src/content/docs/fr/reference/plugins.md

trueberryless · 2025-02-16T08:07:07Z

docs/src/content/docs/fr/reference/plugins.md

 // module-extension.ts
 export default {
-  name: 'plugin-avec-traductions',
+  name: 'plugin-use-translations',


same here, I think it is just a coincidence that it translates to the same (although traductions seems like a valid translation for translations too)... Probably best if the native speakers resolve these comments.

Probably an oversight, thanks trueberryless!

However it seems plugin-use-translations is used in multiple places across the file, so if we update the plugin name we might need to update the other occurrences as well.

This one is tricky (in my head ^^), I initially translated it, then thought the name was not about using translations but the useTranslations() function being documented in this section, so I partially translated it to module-extension-use-translation, ended up not liking it and reverting back to the English version.

😅

Oh, I didn't make the connection with useTranslations! 😆 For me, it was just to show the contrast with the other snippet l85: plugin-with-translations/plugin-avec-traductions. So, here I would use plugin-use-translations/plugin-utilisant-traductions. But, yeah, we could use module-extension to be consistent (l85 as well).

Yeah, it was probably my brain seeing hidden things that weren't there like I said 😅 Went ahead and used your suggestion, thanks a lot 🙌

docs/src/content/docs/fr/reference/plugins.md

ArmandPhilippot

Three little suggestions, otherwise LGTM!

docs/src/content/docs/fr/reference/plugins.md

ArmandPhilippot · 2025-02-16T17:26:51Z

docs/src/content/docs/fr/reference/plugins.md

 // module-extension.ts
 export default {
-  name: 'plugin-avec-traductions',
+  name: 'plugin-use-translations',


Probably an oversight, thanks trueberryless!

However it seems plugin-use-translations is used in multiple places across the file, so if we update the plugin name we might need to update the other occurrences as well.

docs/src/content/docs/fr/reference/plugins.md

Co-authored-by: Armand Philippot <git@armand.philippot.eu>

HiDeoo · 2025-02-16T18:17:33Z

Thanks for the great catches. Still not sure about this use-translations ^^ I'll sleep on it and decide something if someone doesn't have a strong opinion on it before.

Co-authored-by: Armand Philippot <59021693+ArmandPhilippot@users.noreply.github.com>

trueberryless · 2025-02-16T18:53:14Z

One thing which you could do about the use-translations topic:

I have reviewed the Korean and Russian version and written the German one, all have not translated any of the plugin names...
So you could also just not translate it I guess, but as you like, you know French better then I do 😅

trueberryless · 2025-02-16T18:55:02Z

docs/src/content/docs/fr/reference/plugins.md

@@ -73,7 +170,7 @@ Dans l'exemple suivant, un nouveau compte de média [`social`](/fr/reference/con
 export default {
  name: 'ajout-twitter-plugin',


For consistency you should also not translate these if you chose to..

trueberryless · 2025-02-16T18:55:07Z

docs/src/content/docs/fr/reference/plugins.md

@@ -100,7 +197,7 @@ import react from '@astrojs/react';
 export default {
  name: 'plugin-utilisant-react',


trueberryless · 2025-02-16T18:55:27Z

docs/src/content/docs/fr/reference/plugins.md

@@ -149,7 +280,7 @@ Tous les messages seront préfixés par le nom du module d'extension.
 export default {
  name: 'plugin-long-processus',


and one over here and so on...

HiDeoo · 2025-02-16T18:58:01Z

I have reviewed the Korean and Russian version and written the German one, all have not translated any of the plugin names...
So you could also just not translate it I guess, but as you like, you know French better then I do 😅

Yeah, this is something up to translators and that has been consistently done in the French versions where it doesn't change a meaning or make it harder to understand. I personally think it adds a nice touch to the translation and shows that the translator has put some thought into it.

* main: (493 commits) i18n(de): update `sidebar.mdx` (withastro#2900) Adding all samples for badges in sidebar as example (withastro#2881) i18n(fr): fix highlighting in `reference/plugins.md` (withastro#2898) i18n(fr): update `reference/plugins` & `guides/i18n` (withastro#2886) i18n(fr): update `reference/overrides` & `guides/sidebar` (withastro#2887) i18n(fr): add `guides/route-data` and `reference/route-data` (withastro#2884) i18n(fr): update `guides/overriding-components` (withastro#2885) i18n(fr): update `reference/configuration` (withastro#2888) i18n(de): update German translation with withastro#2578 (withastro#2882) [ci] format i18n(ru): update some translations (withastro#2895) i18n(de): update `reference/configuration.mdx` (withastro#2883) [ci] format i18n(ko-KR): update `configuration.mdx` (withastro#2892) i18n(ko-KR): update `overrides.md` (withastro#2893) i18n(ko-KR): update `overriding-components.mdx` (withastro#2890) i18n(ko-KR): update `i18n.mdx` and `plugins.md` (withastro#2889) [ci] format i18n(ko-KR): create `guides/route-data.mdx` and `reference/route-data.mdx` (withastro#2896) i18n(ko-KR): update `/resources/plugins.mdx` (withastro#2894) ...

i18n(fr): update reference/plugins & guides/i18n

dfeffce

github-actions bot added i18n Anything to do with internationalization & translation efforts 📚 docs Documentation website changes labels Feb 16, 2025

trueberryless approved these changes Feb 16, 2025

View reviewed changes

ArmandPhilippot reviewed Feb 16, 2025

View reviewed changes

docs: apply suggestions

e57733b

Co-authored-by: Armand Philippot <git@armand.philippot.eu>

HiDeoo and others added 2 commits February 16, 2025 19:52

docs: update example plugin name

d5e4a1d

Co-authored-by: Armand Philippot <59021693+ArmandPhilippot@users.noreply.github.com>

Merge branch 'main' into hd-i18n-fr-0-32-guide-i18n-reference-plugins

db70ec7

trueberryless reviewed Feb 16, 2025

View reviewed changes

HiDeoo merged commit a22d4e6 into withastro:main Feb 16, 2025

ArmandPhilippot mentioned this pull request Feb 17, 2025

i18n(fr): fix highlighting in reference/plugins.md #2898

Merged

		@@ -73,7 +170,7 @@ Dans l'exemple suivant, un nouveau compte de média [`social`](/fr/reference/con
		export default {
		name: 'ajout-twitter-plugin',

		@@ -100,7 +197,7 @@ import react from '@astrojs/react';
		export default {
		name: 'plugin-utilisant-react',

		@@ -149,7 +280,7 @@ Tous les messages seront préfixés par le nom du module d'extension.
		export default {
		name: 'plugin-long-processus',

Uh oh!

Conversation

HiDeoo commented Feb 16, 2025

Description

Uh oh!

changeset-bot bot commented Feb 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

netlify bot commented Feb 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for astro-starlight ready!

Uh oh!

astrobot-houston commented Feb 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Lunaria Status Overview

Tracked Files

Uh oh!

trueberryless left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ArmandPhilippot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

HiDeoo commented Feb 16, 2025

Uh oh!

trueberryless commented Feb 16, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

HiDeoo commented Feb 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

changeset-bot bot commented Feb 16, 2025 •

edited

Loading

netlify bot commented Feb 16, 2025 •

edited

Loading

astrobot-houston commented Feb 16, 2025 •

edited

Loading