Skip to content

Fixes import name typo in Customize icons example#2572

Merged
delucis merged 2 commits intowithastro:mainfrom
brianzelip:patch-1
Nov 4, 2024
Merged

Fixes import name typo in Customize icons example#2572
delucis merged 2 commits intowithastro:mainfrom
brianzelip:patch-1

Conversation

@brianzelip
Copy link
Copy Markdown
Contributor

@brianzelip brianzelip commented Nov 4, 2024

Description

This PR fixes a typo in the "Customize icons" section of the Icon component docs where Card was imported instead of Icon.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Nov 4, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: b4e89b2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the 📚 docs Documentation website changes label Nov 4, 2024
@netlify
Copy link
Copy Markdown

netlify bot commented Nov 4, 2024 •
edited
Loading

✅ Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit b4e89b2
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/6728ba7cefbc9900084b5f44
😎 Deploy Preview https://deploy-preview-2572--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Nov 4, 2024

Hello! Thank you for opening your first PR to Starlight! ✨

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any issues you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🤩

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Nov 4, 2024 •
edited
Loading

Lunaria Status Overview

🌑 This pull request will not trigger status changes.

Learn more

Lunaria automatically ignores changes on specific PRs by adding a ignored keyword in its title. Found: typo.

You can change this by either removing the keyword above from the PR's title, or modifying the ignoreKeywords property in your Lunaria configuration file.

Tracked Files

Note

The notes below indicate what would happen if the pull request is merged when triggering status changes. Since a ignored keyword was found in the PR's title, the status changes indicated below won't be applied.

Locale File Note
en components/icons.mdx Source changed, localizations will be marked as outdated.
de components/icons.mdx Localization changed, will be marked as complete.
es components/icons.mdx Localization changed, will be marked as complete.
fr components/icons.mdx Localization changed, will be marked as complete.
ja components/icons.mdx Localization changed, will be marked as complete.
ko components/icons.mdx Localization changed, will be marked as complete.
ru components/icons.mdx Localization changed, will be marked as complete.
zh-cn components/icons.mdx Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts label Nov 4, 2024
@delucis delucis changed the title Fixes import name in Customize icons example Fixes import name typo in Customize icons example Nov 4, 2024
delucis
delucis approved these changes Nov 4, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for spotting that and fixing it @brianzelip — appreciate it 🙌

@delucis delucis merged commit 204b1f3 into withastro:main Nov 4, 2024
@brianzelip brianzelip deleted the patch-1 branch November 4, 2024 12:24
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Nov 6, 2024
@HiDeoo
Merge branch 'main' into hd-feat-ci-a11y
0fb18f7 
* main: (82 commits)
  i18n(ja): Update site-search.mdx (withastro#2577)
  i18n(ja): Update pages.mdx (withastro#2576)
  i18n(fr): Update `reference/plugins.mdx` from withastro#2549 (withastro#2574)
  [ci] format
  docs: update showcase-sites.astro (withastro#2562)
  Throw an error if a showcase image does not have the required dimensions (withastro#2573)
  i18n(ja): Update frontmatter.md (withastro#2566)
  Fixes import name typo in Customize icons example (withastro#2572)
  [ci] release (withastro#2570)
  Prettier ignore a malformed YAML test file (withastro#2571)
  Add YAML support to the FS translation system (withastro#2565)
  i18n(ja): Update reference/icons.mdx (withastro#2564)
  i18n(ja): Update overrides.md (withastro#2567)
  i18n(zh-cn): Update `plugins.mdx` (withastro#2568)
  i18n(ja): Update customization.mdx (withastro#2560)
  i18n(ja): Update css-and-tailwind.mdx (withastro#2559)
  i18n(ru): update `icons.mdx` and `overrides.md` (withastro#2558)
  i18n(ru): update `i18n.mdx` and `overriding-components.mdx` (withastro#2557)
  i18n(ko-KR): update `plugins.mdx` (withastro#2556)
  i18n(ru): update `plugins.mdx` (withastro#2555)
  ...
@trueberryless trueberryless mentioned this pull request Feb 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@delucis delucis delucis approved these changes

Assignees

No one assigned

Labels

📚 docs Documentation website changes i18n Anything to do with internationalization & translation efforts

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brianzelip @astrobot-houston @delucis