docs: update showcase-sites.astro#2562
docs: update showcase-sites.astro#2562delucis merged 9 commits intowithastro:mainfrom rishi-raj-jain:main
Conversation
|
✅ Deploy Preview for astro-starlight ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
apatel369
left a comment
There was a problem hiding this comment.
Verified that cards are rendered correctly with correct link and image.
delucis
left a comment
There was a problem hiding this comment.
Thanks @rishi-raj-jain! Can you resize the screenshots to match the dimensions described in our contributing guide?
https://github.com/withastro/starlight/blob/main/CONTRIBUTING.md#showcase
delucis
left a comment
There was a problem hiding this comment.
Hmm, if I’m not mistaken, these screenshots are 1600x900px, i.e. twice the size expected. Here are my steps for producing screenshots usually in case it helps:
-
Take a screenshot of the site using a browser resized to 1280×720px. The responsive view in dev tools can be helpful for this.
-
Resize the screenshot to 800×450px and make sure it is saved as a PNG. An online tool like Squoosh can help here.
|
@delucis can you take the latest git pull? I now uploaded by resizing the dimension during the screenshot itself. To verify, you can view the raw file from git and hover over the tab to see the dimension. |
|
Interesting! this is still at 1600*900. Let me do the update later today. Even though I resized the browser during the screenshot. |
Yeah, probably due to the screen resolution. On high resolution (aka “retina”) displays, there is actually more than one device pixel for every 1 “web pixel” and screenshots include all of these. |
|
@rishi-raj-jain I just updated branch for this PR to pull in changes from #2573 — that PR added a programmatic check for the image dimensions, so we should get easier confirmation if the screenshots are the right size or not! |
|
@delucis Should be all good now. |
delucis
left a comment
There was a problem hiding this comment.
Woo, looks good! Thanks for putting up with the fussy dimensions. I’m happy we got to test out the new test too so I have more confidence about these PRs when reviewing them 🙌
Nice! |
|
Appreciate your patience as well. |
* main: (82 commits) i18n(ja): Update site-search.mdx (withastro#2577) i18n(ja): Update pages.mdx (withastro#2576) i18n(fr): Update `reference/plugins.mdx` from withastro#2549 (withastro#2574) [ci] format docs: update showcase-sites.astro (withastro#2562) Throw an error if a showcase image does not have the required dimensions (withastro#2573) i18n(ja): Update frontmatter.md (withastro#2566) Fixes import name typo in Customize icons example (withastro#2572) [ci] release (withastro#2570) Prettier ignore a malformed YAML test file (withastro#2571) Add YAML support to the FS translation system (withastro#2565) i18n(ja): Update reference/icons.mdx (withastro#2564) i18n(ja): Update overrides.md (withastro#2567) i18n(zh-cn): Update `plugins.mdx` (withastro#2568) i18n(ja): Update customization.mdx (withastro#2560) i18n(ja): Update css-and-tailwind.mdx (withastro#2559) i18n(ru): update `icons.mdx` and `overrides.md` (withastro#2558) i18n(ru): update `i18n.mdx` and `overriding-components.mdx` (withastro#2557) i18n(ko-KR): update `plugins.mdx` (withastro#2556) i18n(ru): update `plugins.mdx` (withastro#2555) ...
* main: (27 commits) i18n(ko-KR): update `site-search.mdx` [ci] release (withastro#2590) Support passing more options to the DocSearch component (withastro#2589) [ci] release (withastro#2587) Add changeset for withastro#2252 (withastro#2588) [ci] format Update dev dependencies (withastro#2582) Build performance optimizations for projects with large sidebars (withastro#2252) Fix a11y CI workflow (withastro#2503) Update `astro-expressive-code` to v0.38 (withastro#2551) Added social icon for Nostr (withastro#2579) [ci] format docs(showcase): add docs.reactbricks.com to showcase (withastro#2586) i18n(ja): Update site-search.mdx (withastro#2577) i18n(ja): Update pages.mdx (withastro#2576) i18n(fr): Update `reference/plugins.mdx` from withastro#2549 (withastro#2574) [ci] format docs: update showcase-sites.astro (withastro#2562) Throw an error if a showcase image does not have the required dimensions (withastro#2573) i18n(ja): Update frontmatter.md (withastro#2566) ...
Description