⚠️ No Changeset found

Latest commit: 77fa15f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Thanks for the update and the review.

Small question: I see that labels like "constellations", "moons", "stars", etc. are not translated and same for constellation names like "Andromeda". Is this on purpose? Do you think it's better to leave them in English? Is this a domain-specific where English is more common? Could something like "Andromeda" be translated to "仙女座" or this would not make sense?

Of course, this is just a question, you definitely know better than me what is best in this case and I'd like your opinions.

Thanks for the update and the review.

Small question: I see that labels like "constellations", "moons", "stars", etc. are not translated and same for constellation names like "Andromeda". Is this on purpose? Do you think it's better to leave them in English? Is this a domain-specific where English is more common? Could something like "Andromeda" be translated to "仙女座" or this would not make sense?

Of course, this is just a question, you definitely know better than me what is best in this case and I'd like your opinions.

Hi HiDeoo, nice to communicate with you.

I didn't translate these contents for the following reasons.

1. Some of the content involves paths and filenames, which are usually not set in Chinese due to issues such as sorting. Translating them into Chinese would be somewhat counterintuitive.

2. In my opinion, in an English-speaking environment, these terms in the documentation have a kind of easter egg feel for Starlight. However, as far as I know, the educational foundation in Chinese-speaking environments rarely includes a knowledge system about astronomy or constellations. People are not sensitive to these terms in Chinese, and translating them might actually make it harder to understand.

3. The most important point is to differentiate from the i18n content below, so that readers can better understand the use of basics and the use of internationalization.

Thanks for the update and the review.

Small question: I see that labels like "constellations", "moons", "stars", etc. are not translated and same for constellation names like "Andromeda". Is this on purpose? Do you think it's better to leave them in English? Is this a domain-specific where English is more common? Could something like "Andromeda" be translated to "仙女座" or this would not make sense?

Of course, this is just a question, you definitely know better than me what is best in this case and I'd like your opinions.

Nope. This is not English domain-specific. I think it would be fun to translate them too.
For Default sidebar, I'm not sure whether if need translate, because we don't usually use Chinese for file paths. Maybe we should keep them in English?

Thanks you both for your feedback, really appreciated.

Thanks for the update and the review.
Small question: I see that labels like "constellations", "moons", "stars", etc. are not translated and same for constellation names like "Andromeda". Is this on purpose? Do you think it's better to leave them in English? Is this a domain-specific where English is more common? Could something like "Andromeda" be translated to "仙女座" or this would not make sense?
Of course, this is just a question, you definitely know better than me what is best in this case and I'd like your opinions.

Nope. This is not English domain-specific. I think it would be fun to translate them too. For Default sidebar, I'm not sure whether if need translate, because we don't usually use Chinese for file paths. Maybe we should keep them in English?

Indeed, and I guess having /constellations/something but the label being translated is not as obvious as having /constellations/something and the label being "Constellations" as pointed out by @huyikai.

The most important point is to differentiate from the i18n content below, so that readers can better understand the use of basics and the use of internationalization.

What is done in the French translation for example, is that default labels are translated in French but we keep the original translations in pt-BR so readers can still see the internationalization in action. Altho, again, it's easier as having file paths in French is not an issue and fairly common.

Considering all this, maybe only "Resources" in this section should be translated as this is a safe one, right?

Tiny update if this can help the discussion: we had the same discussion for the ko-KR PR where the final result is mostly translated except some very specific terms ("New", "Outdated", "Stub") which did not make sense. Maybe it could help figuring out what is best in this case.

Tiny update if this can help the discussion: we had the same discussion for the ko-KR PR where the final result is mostly translated except some very specific terms ("New", "Outdated", "Stub") which did not make sense. Maybe it could help figuring out what is best in this case.

Well, I looked at the final result of the ko-KR, and I think it is reasonable, so I added the Chinese translation with reference to the ko-KR.

Thanks for the update, this is looking really great 👍

I left a few suggestions for the case of nested folders in autogenerated groups which would use the folder name (this would also becomes more obvious for readers with the translated content that we do not support this yet as nested folders would be using the folder name in English).

Except for that, everything looks in order to me.

Thanks for your correction. I submitted your suggestions. Could you please confirm again.