i18n(ko-KR): update sidebar.mdx#1760
i18n(ko-KR): update sidebar.mdx#1760HiDeoo merged 9 commits intowithastro:mainfrom jsparkdev:sidebar
sidebar.mdx#1760Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
HiDeoo
left a comment
There was a problem hiding this comment.
Thanks for the update, this is looking really great.
Small question: I noticed you did not translate the new examples (they can safely be translated). Is this intentional? Do you think it would be better to leave them in English? Is this a domain-specific where English is more common? For example, if I am not wrong, Andromeda is 안드로메다자리 and we have more generic terms like "stars", "constellations", "moons", etc. that I guess could be translated?
Just a question of course, you definitely know better than me what is best in this case so feel free to tell me if I am wrong and things are better this way.
|
Thank you! I translated the content that I thought was natural to translate. I left badges containing |
HiDeoo
left a comment
There was a problem hiding this comment.
Thanks a lot for taking the time to update the translation, this looks amazing and what you did not change makes total sense to me.
I left a few suggestions for the case of no config or folders in autogenerated groups where the folder names are used (as we have no API at the moment to properly translate them) but once fixed, this is ready to go 🚀
Co-authored-by: HiDeoo <494699+HiDeoo@users.noreply.github.com>
Co-authored-by: HiDeoo <494699+HiDeoo@users.noreply.github.com>
Co-authored-by: HiDeoo <494699+HiDeoo@users.noreply.github.com>
Co-authored-by: HiDeoo <494699+HiDeoo@users.noreply.github.com>
Co-authored-by: HiDeoo <494699+HiDeoo@users.noreply.github.com>
|
Thank you. Added suggestions for default sidebar and autogenerated group. |
HiDeoo
left a comment
There was a problem hiding this comment.
Amazing, thanks for your patience, this looks great 🌟 (I pushed a tiny commit to add a missing quote introduced by one of my suggestions 🥲)
* main: (32 commits) i18n(pt-br): Update `getting-started.mdx` (withastro#1776) i18n(es): update `configuration` (withastro#1766) [ci] format Add TrueCharts to showcases (withastro#1773) i18n(zh-cn): Update `sidebar.mdx` (withastro#1761) i18n(ko-KR): update `sidebar.mdx` (withastro#1760) i18n(fr): update `guides/sidebar` (withastro#1758) test: fix Windows path separator test issues (withastro#1759) i18n(fr): Update `reference/configuration.mdx` from withastro#1729 (withastro#1757) docs: rewrite `guides/sidebar` examples to be more generic (withastro#1751) i18n(ja): Update community-content.mdx (withastro#1756) i18n(ja): Update configuration.mdx (withastro#1755) i18n(zh-cn): Update `configuration.mdx` (withastro#1753) i18n(ko-KR): update `configuration.mdx` (withastro#1752) docs: add caution about scripts processing when using head config (withastro#1729) i18n(es): update `community-content` (withastro#1740) i18n(pt-br): Update `resources/community-content.mdx` (withastro#1747) format: quick fix [ci] format [ci] format ...
* main: (21 commits) Update fa.json (withastro#1793) i18n(fr): update `resources/community-content.mdx` (withastro#1795) [ci] format i18n(ko-KR): update `community-content.mdx` (withastro#1794) [ci] format Adds Starlight in Next.js project video (withastro#1789) [ci] format i18n(ru): update translations (withastro#1783) i18n(id): Update getting-started.mdx (withastro#1778) Upgrade Lunaria and add Action (withastro#1768) [ci] format i18n(es): update `sidebar` (withastro#1767) i18n(pt-br): Update `getting-started.mdx` (withastro#1776) i18n(es): update `configuration` (withastro#1766) [ci] format Add TrueCharts to showcases (withastro#1773) i18n(zh-cn): Update `sidebar.mdx` (withastro#1761) i18n(ko-KR): update `sidebar.mdx` (withastro#1760) i18n(fr): update `guides/sidebar` (withastro#1758) test: fix Windows path separator test issues (withastro#1759) ...
Description
sidebar.mdxguides/sidebarexamples to be more generic #1751