[i18nIgnore] [reference] new components page#9465
Merged
sarah11918 merged 16 commits intomainfrom Oct 5, 2024
Merged
Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
Lunaria Status Overview🌑 This pull request will not trigger status changes. Learn moreLunaria automatically ignores changes on specific PRs by adding a ignored keyword in its title. Found: You can change this by either removing the keyword above from the PR's title, or modifying the Tracked FilesNote The notes below indicate what would happen if the pull request is merged when triggering status changes. Since a ignored keyword was found in the PR's title, the status changes indicated below won't be applied.
Warnings reference
|
Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
sarah11918
commented
Sep 27, 2024
Member
ArmandPhilippot
left a comment
There was a problem hiding this comment.
Regarding the split, I have nothing to say... besides reducing the size of api-reference.mdx, I think it adds visibility for those only interested in components. So, LGTM!
But since I'm here... some nitpicking regarding code snippets. 😄
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
VoxelMC
reviewed
Oct 5, 2024
Contributor
VoxelMC
left a comment
There was a problem hiding this comment.
Awesome, LGTM. Thank you!
This will make these more intuitive to find for sure!
A few tiny comments are all I have for ya.
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: voxel!() <voxelmc@hotmail.com>
Co-authored-by: voxel!() <voxelmc@hotmail.com>
Member
Author
|
!coauthor |
|
sarah11918
commented
Oct 5, 2024
Comment on lines
+4
to
+6
| tableOfContents: | ||
| minHeadingLevel: 2 | ||
| maxHeadingLevel: 2 |
Member
Author
There was a problem hiding this comment.
Until we go through and structure this page and we decide what it will look like, temporary fix so that only the components show up in the TOC.
(The alternative would be to convert ### to <h3>, which would also be fine! This way preserves our normal Markdown authoring.)
sarah11918
commented
Oct 5, 2024
| import PackageManagerTabs from '~/components/tabs/PackageManagerTabs.astro'; | ||
| import ReadMore from '~/components/ReadMore.astro'; | ||
|
|
||
| Astro includes several built-in components for you to use in your projects. All built-in components are available in `.astro` files via `import {} from 'astro:components'`. |
Member
Author
There was a problem hiding this comment.
The heading that was here was redundant (pulled directly from the other page where it was simply a page section.)
This means we don't need it here, and all the components can be ##.
sarah11918
commented
Oct 5, 2024
ArmandPhilippot
added a commit
to ArmandPhilippot/astro-docs
that referenced
this pull request
Oct 7, 2024
Nin3lee
added a commit
to Nin3lee/docs
that referenced
this pull request
Oct 8, 2024
yanthomasdev
added a commit
that referenced
this pull request
Oct 8, 2024
* i18n(fr): add `components-reference.mdx` See #9465 * reword: ceci > il Co-authored-by: pioupia <49518790+pioupia@users.noreply.github.com> --------- Co-authored-by: pioupia <49518790+pioupia@users.noreply.github.com> Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
trueberryless
added a commit
to trueberryless/withastro-docs
that referenced
this pull request
Oct 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (required)
This splits out the "Built-in components" section at the bottom of API reference into its own page. This makes them easier to find, and helps with the API reference page getting too long for Algolia to properly index