Skip to content

feat: add empty slot fallback content info (#8302)#8393

Merged
sarah11918 merged 6 commits intowithastro:mainfrom
jdtjenkins:feat/8302
Jun 5, 2024
Merged

feat: add empty slot fallback content info (#8302)#8393
sarah11918 merged 6 commits intowithastro:mainfrom
jdtjenkins:feat/8302

Conversation

@jdtjenkins
Copy link
Copy Markdown
Contributor

@jdtjenkins jdtjenkins commented May 24, 2024

Description (required)

This PR adds an example of how passing empty slots causes that slot's default content to not render.

Related issues & labels (optional)

For a new/changed feature in an upcoming Astro release?

No

First-time contributor to Astro Docs?

Yes :3

Discord: Jumper#8174

@jdtjenkins jdtjenkins added the improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) label May 24, 2024
@vercel
Copy link
Copy Markdown

vercel bot commented May 24, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Jun 5, 2024 4:27pm

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented May 24, 2024

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Vercel 🥳

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented May 24, 2024 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en basics/astro-components.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

at-the-vr
at-the-vr approved these changes May 26, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@at-the-vr at-the-vr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looking great already Jumper 🔥 although
⚠️ nit warning ⚠️
I believe the title for components could match docs theme that is name for components themselves. Besides that, this is LGTM 👍

sarah11918
sarah11918 reviewed Jun 3, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOOK WHO MADE A DOCS PR!!! 😄

Thanks for jumping on this issue, @jdtjenkins ! So, I kind of started by trying to go extreme minimum to figure out what is enough to be helpful here.

See what you think, and we can negotiate how much more is needed!

@sarah11918 sarah11918 added add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. and removed improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) labels Jun 3, 2024
sarah11918
sarah11918 reviewed Jun 4, 2024
View reviewed changes
@jdtjenkins jdtjenkins requested a review from sarah11918 June 5, 2024 15:17
sarah11918
sarah11918 approved these changes Jun 5, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally getting you into Team Docs @jdtjenkins ! 🥳

@sarah11918 sarah11918 merged commit 15b105c into withastro:main Jun 5, 2024
@huyikai huyikai mentioned this pull request Jun 6, 2024
Merged
@jsparkdev jsparkdev mentioned this pull request Jun 6, 2024
Merged
@at-the-vr at-the-vr mentioned this pull request Aug 8, 2024
Merged
trueberryless added a commit to trueberryless/withastro-docs that referenced this pull request Oct 20, 2024
@trueberryless
update translation withastro#8302 withastro#8393
f90e3ec
@trueberryless trueberryless mentioned this pull request Oct 20, 2024
Merged
yanthomasdev added a commit that referenced this pull request Nov 4, 2024
@trueberryless @yanthomasdev
i18n(de): update basics/astro-components.mdx (#9754)
791e2b3 
* update translation #9465

* update translation #8302 #8393

* update translation #6864

* update translation #5712

* fix heading levels (couldnt find pr history changes on en version)

---------

Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
@vrabe vrabe mentioned this pull request Jan 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sarah11918 sarah11918 sarah11918 approved these changes

@at-the-vr at-the-vr Awaiting requested review from at-the-vr

Assignees

No one assigned

Labels

add new content Document something that is not in docs. May require testing, confirmation, or affect other pages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve documentation on fallback content for slots

4 participants

@jdtjenkins @astrobot-houston @sarah11918 @at-the-vr