Add reference for named slot functions#8946
Merged
BryceRussell merged 4 commits intomainfrom Jul 30, 2024
Merged
Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
sarah11918
reviewed
Jul 30, 2024
Member
sarah11918
left a comment
There was a problem hiding this comment.
This looks great, @BryceRussell ! Thank you so much for tackling this! See my comment below re: can we make advice easier if we suggest that the tag should be a standard HTML element.
I get that the naming of the tag is arbitrary, but I wonder whether presenting it as an element avoids some of the naming restrictions we don't want them to get tripped up by?
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
sarah11918
reviewed
Jul 30, 2024
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
sarah11918
reviewed
Jul 30, 2024
sarah11918
approved these changes
Jul 30, 2024
Member
sarah11918
left a comment
There was a problem hiding this comment.
Looks great, thanks for this @BryceRussell ! Merge whenever you're happy with it!
thomasbnt
added a commit
to thomasbnt/docs
that referenced
this pull request
Jul 31, 2024
Co-authored-by: Armand Philippot <59021693+ArmandPhilippot@users.noreply.github.com>
yanthomasdev
added a commit
that referenced
this pull request
Aug 1, 2024
…pi-reference.mdx` (#8944) * i18n(fr): Add `reference/api-refenrece.mdx` L0 to L501 now, miss L502 to L1026 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Add `reference/api-refenrece.mdx` L502 to L1026 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Fix links Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): translate api-reference.mdx from l1026 to end * i18n(fr): Fix links, remove "NBSP" space and fix typo at "régionaux" L1570 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * Update src/content/docs/fr/reference/api-reference.mdx Co-authored-by: Armand Philippot <59021693+ArmandPhilippot@users.noreply.github.com> * Update src/content/docs/fr/reference/api-reference.mdx Co-authored-by: Armand Philippot <59021693+ArmandPhilippot@users.noreply.github.com> * Update src/content/docs/fr/reference/api-reference.mdx Co-authored-by: Armand Philippot <59021693+ArmandPhilippot@users.noreply.github.com> * Update src/content/docs/fr/reference/api-reference.mdx Co-authored-by: Armand Philippot <59021693+ArmandPhilippot@users.noreply.github.com> * Update src/content/docs/fr/reference/api-reference.mdx Co-authored-by: Armand Philippot <59021693+ArmandPhilippot@users.noreply.github.com> * Update src/content/docs/fr/reference/api-reference.mdx Co-authored-by: Armand Philippot <59021693+ArmandPhilippot@users.noreply.github.com> * Update src/content/docs/fr/reference/api-reference.mdx Co-authored-by: Armand Philippot <59021693+ArmandPhilippot@users.noreply.github.com> * Update src/content/docs/fr/reference/api-reference.mdx Co-authored-by: Armand Philippot <59021693+ArmandPhilippot@users.noreply.github.com> * Update src/content/docs/fr/reference/api-reference.mdx Co-authored-by: Armand Philippot <59021693+ArmandPhilippot@users.noreply.github.com> * i18n(fr): Update `reference/dev-toolbar-reference.mdx` from #8923 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * Update src/content/docs/fr/reference/api-reference.mdx Co-authored-by: Armand Philippot <59021693+ArmandPhilippot@users.noreply.github.com> * i18n(fr): Update `guides/routing.mdx` from #8941 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * Update src/content/docs/fr/reference/api-reference.mdx Co-authored-by: Armand Philippot <59021693+ArmandPhilippot@users.noreply.github.com> * Update src/content/docs/fr/guides/routing.mdx Co-authored-by: Armand Philippot <59021693+ArmandPhilippot@users.noreply.github.com> * Update src/content/docs/fr/guides/routing.mdx Co-authored-by: Armand Philippot <59021693+ArmandPhilippot@users.noreply.github.com> * Updating file since #8946 Co-authored-by: Armand Philippot <59021693+ArmandPhilippot@users.noreply.github.com> * i18n(fr): Fix typo in from #8947 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update `guides/routing.mdx` from #8967 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update `reference/api-reference.mdx` from #8967 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * chore: Mettre à jour la documentation de référence de l'API --------- Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> Co-authored-by: Armand Philippot <git@armand.philippot.eu> Co-authored-by: Armand Philippot <59021693+ArmandPhilippot@users.noreply.github.com> Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (required)
This PR partially addresses issue #8855 by adding an example for named slot functions to the reference page for
Astro.slots.render()Related issues & labels (optional)