Skip to content

i18n(fr): Update guides/routing.mdx from #8941 and add reference/api-reference.mdx #8944

Merged
yanthomasdev merged 34 commits intowithastro:mainfrom
thomasbnt:i18n-update-fr-guides-routing
Aug 1, 2024
Merged

i18n(fr): Update guides/routing.mdx from #8941 and add reference/api-reference.mdx #8944
yanthomasdev merged 34 commits intowithastro:mainfrom
thomasbnt:i18n-update-fr-guides-routing

Conversation

@thomasbnt
Copy link
Copy Markdown
Member

@thomasbnt thomasbnt commented Jul 29, 2024 •
edited
Loading

Description (required)

Update guides/routing.mdx from #8941

The link at 429 is good, see https://deploy-preview-8922--astro-docs-2.netlify.app/fr/reference/api-reference/#le-prop-page-de-pagination from #8922

Add reference/api-reference.mdx with @ArmandPhilippot for the second part.

Related issues & labels (optional)

  • Suggested label: i18n

thomasbnt and others added 21 commits July 25, 2024 00:40
@thomasbnt
i18n(fr): Add reference/api-refenrece.mdx L0 to L501 now, miss L502…
41073fb 
… to L1026

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
@thomasbnt
i18n(fr): Add reference/api-refenrece.mdx L502 to L1026
4d39cf9 
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
@thomasbnt
i18n(fr): Fix links
821ccad 
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
@ArmandPhilippot
i18n(fr): translate api-reference.mdx from l1026 to end
7890568
@thomasbnt
i18n(fr): translate api-reference.mdx from l1026 to end (#1)
1378090
@thomasbnt
Merge branch 'main' into i18n-fr-add-reference-api-reference
eb66ae2
@thomasbnt
i18n(fr): Fix links, remove "NBSP" space and fix typo at "régionaux" …
12ea581 
…L1570

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
@thomasbnt @ArmandPhilippot
Update src/content/docs/fr/reference/api-reference.mdx
7f36e0c 
Co-authored-by: Armand Philippot <59021693+ArmandPhilippot@users.noreply.github.com>
@thomasbnt @ArmandPhilippot
Update src/content/docs/fr/reference/api-reference.mdx
7976b79 
Co-authored-by: Armand Philippot <59021693+ArmandPhilippot@users.noreply.github.com>
@thomasbnt @ArmandPhilippot
Update src/content/docs/fr/reference/api-reference.mdx
bf0377f 
Co-authored-by: Armand Philippot <59021693+ArmandPhilippot@users.noreply.github.com>
@thomasbnt @ArmandPhilippot
Update src/content/docs/fr/reference/api-reference.mdx
b359884 
Co-authored-by: Armand Philippot <59021693+ArmandPhilippot@users.noreply.github.com>
@thomasbnt @ArmandPhilippot
Update src/content/docs/fr/reference/api-reference.mdx
8627f72 
Co-authored-by: Armand Philippot <59021693+ArmandPhilippot@users.noreply.github.com>
@thomasbnt @ArmandPhilippot
Update src/content/docs/fr/reference/api-reference.mdx
5df4813 
Co-authored-by: Armand Philippot <59021693+ArmandPhilippot@users.noreply.github.com>
@thomasbnt @ArmandPhilippot
Update src/content/docs/fr/reference/api-reference.mdx
4bbaf68 
Co-authored-by: Armand Philippot <59021693+ArmandPhilippot@users.noreply.github.com>
@thomasbnt @ArmandPhilippot
Update src/content/docs/fr/reference/api-reference.mdx
19a2dc8 
Co-authored-by: Armand Philippot <59021693+ArmandPhilippot@users.noreply.github.com>
@thomasbnt @ArmandPhilippot
Update src/content/docs/fr/reference/api-reference.mdx
2e73ea1 
Co-authored-by: Armand Philippot <59021693+ArmandPhilippot@users.noreply.github.com>
@thomasbnt
Merge branch 'main' into i18n-fr-add-reference-api-reference
270abb9
@thomasbnt
i18n(fr): Update reference/dev-toolbar-reference.mdx from withastro…
d0d3b62 
…#8923

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
@thomasbnt @ArmandPhilippot
Update src/content/docs/fr/reference/api-reference.mdx
1f79e92 
Co-authored-by: Armand Philippot <59021693+ArmandPhilippot@users.noreply.github.com>
@thomasbnt
Merge branch 'main' into i18n-fr-add-reference-api-reference
0c5623c
@thomasbnt
i18n(fr): Update guides/routing.mdx from withastro#8941
eabfcba 
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Jul 29, 2024
@netlify
Copy link
Copy Markdown

netlify bot commented Jul 29, 2024 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 5d75992
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/66ac0642821c95000878846b
😎 Deploy Preview https://deploy-preview-8944--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Jul 29, 2024 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
fr guides/content-collections.mdx Localization changed, will be marked as complete. 🔄️
fr guides/endpoints.mdx Localization changed, will be marked as complete.
fr guides/imports.mdx Localization changed, will be marked as complete.
fr guides/internationalization.mdx Localization changed, will be marked as complete.
fr guides/middleware.mdx Localization changed, will be marked as complete. 🔄️
fr guides/routing.mdx Localization changed, will be marked as complete. 🔄️
fr guides/server-side-rendering.mdx Localization changed, will be marked as complete.
fr reference/api-reference.mdx Localization added, will be marked as complete. 🔄️
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@Nin3lee Nin3lee mentioned this pull request Jul 30, 2024
Merged
ArmandPhilippot
ArmandPhilippot reviewed Jul 30, 2024
View reviewed changes
thomasbnt and others added 4 commits July 30, 2024 13:43
@thomasbnt @ArmandPhilippot
Update src/content/docs/fr/reference/api-reference.mdx
695ef2a 
Co-authored-by: Armand Philippot <59021693+ArmandPhilippot@users.noreply.github.com>
@thomasbnt @ArmandPhilippot
Update src/content/docs/fr/guides/routing.mdx
edf6765 
Co-authored-by: Armand Philippot <59021693+ArmandPhilippot@users.noreply.github.com>
@thomasbnt
Merge branch 'main' into i18n-fr-add-reference-api-reference
24d74c6
@thomasbnt
Merge branch 'main' into i18n-update-fr-guides-routing
32b0cb8
ArmandPhilippot
ArmandPhilippot requested changes Jul 30, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok to leave the translated anchor, however it needs an update because of the change in #8922

@thomasbnt @ArmandPhilippot
Update src/content/docs/fr/guides/routing.mdx
872fe79 
Co-authored-by: Armand Philippot <59021693+ArmandPhilippot@users.noreply.github.com>
@thomasbnt
Copy link
Copy Markdown
Member Author

thomasbnt commented Jul 30, 2024

I'm ok to leave the translated anchor, however it needs an update because of the change in #8922

yes, good!

ArmandPhilippot
ArmandPhilippot approved these changes Jul 30, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @thomasbnt!

Note

The broken link will no longer be broken when #8922 is merged.

dreyfus92
dreyfus92 approved these changes Jul 30, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks everybody! LGTM ✅

thomasbnt and others added 3 commits July 31, 2024 12:51
@thomasbnt @ArmandPhilippot
Updating file since withastro#8946
0f5ec2a 
Co-authored-by: Armand Philippot <59021693+ArmandPhilippot@users.noreply.github.com>
@thomasbnt
Merge branch 'main' into i18n-fr-add-reference-api-reference
462dd75
@thomasbnt
i18n(fr): Fix typo in from withastro#8947
9454189 
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
@thomasbnt thomasbnt mentioned this pull request Aug 1, 2024
Merged
thomasbnt and others added 3 commits August 1, 2024 13:14
yanthomasdev
yanthomasdev reviewed Aug 1, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Could you actually move the changes here to #8922, so we can merge without link issues? It's a bit confusing since all the PRs open depend on one another, but I think getting these two together would unblock that.

yanthomasdev

This comment was marked as duplicate.

Sign in to view

@thomasbnt thomasbnt changed the title i18n(fr): Update guides/routing.mdx from #8941 i18n(fr): Update guides/routing.mdx from #8941 and add `reference/api-reference.mdx Aug 1, 2024
@thomasbnt thomasbnt changed the title i18n(fr): Update guides/routing.mdx from #8941 and add `reference/api-reference.mdx i18n(fr): Update guides/routing.mdx from #8941 and add reference/api-reference.mdx Aug 1, 2024
@thomasbnt
Copy link
Copy Markdown
Member Author

thomasbnt commented Aug 1, 2024

LGTM! Could you actually move the changes here to #8922, so we can merge without link issues? It's a bit confusing since all the PRs open depend on one another, but I think getting these two together would unblock that.

Merged this PR into this one.

yanthomasdev
yanthomasdev approved these changes Aug 1, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good job peeps!

@yanthomasdev yanthomasdev merged commit 51f958a into withastro:main Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ArmandPhilippot ArmandPhilippot ArmandPhilippot approved these changes

@yanthomasdev yanthomasdev yanthomasdev approved these changes

@dreyfus92 dreyfus92 dreyfus92 approved these changes

Assignees

No one assigned

Labels

i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@thomasbnt @astrobot-houston @ArmandPhilippot @yanthomasdev @dreyfus92