i18n(fr): Add reference/api-reference.mdx ft. @ArmandPhilippot#8922
Closed
thomasbnt wants to merge 34 commits intowithastro:mainfrom
Closed
i18n(fr): Add reference/api-reference.mdx ft. @ArmandPhilippot#8922thomasbnt wants to merge 34 commits intowithastro:mainfrom
reference/api-reference.mdx ft. @ArmandPhilippot#8922thomasbnt wants to merge 34 commits intowithastro:mainfrom
Conversation
… to L1026 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Member
Author
|
|
…L1570 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
ArmandPhilippot
requested changes
Jul 25, 2024
Member
ArmandPhilippot
left a comment
There was a problem hiding this comment.
Some small changes, then I think we're good!
Co-authored-by: Armand Philippot <59021693+ArmandPhilippot@users.noreply.github.com>
Co-authored-by: Armand Philippot <59021693+ArmandPhilippot@users.noreply.github.com>
Co-authored-by: Armand Philippot <59021693+ArmandPhilippot@users.noreply.github.com>
Co-authored-by: Armand Philippot <59021693+ArmandPhilippot@users.noreply.github.com>
Co-authored-by: Armand Philippot <59021693+ArmandPhilippot@users.noreply.github.com>
Co-authored-by: Armand Philippot <59021693+ArmandPhilippot@users.noreply.github.com>
Co-authored-by: Armand Philippot <59021693+ArmandPhilippot@users.noreply.github.com>
Co-authored-by: Armand Philippot <59021693+ArmandPhilippot@users.noreply.github.com>
Co-authored-by: Armand Philippot <59021693+ArmandPhilippot@users.noreply.github.com>
ArmandPhilippot
approved these changes
Jul 25, 2024
Member
ArmandPhilippot
left a comment
There was a problem hiding this comment.
LGTM for me!
Caution
I translated the second part of the file so another reviewer could be useful.
reference/api-reference.mdxreference/api-reference.mdx ft. @ArmandPhilippot
Member
|
@thomasbnt Some small changes are required on |
…#8923 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Member
Author
Done! |
Member
|
@thomasbnt Thanks, I didn't realized before that I could suggest changes on multiple lines. 😅 |
Co-authored-by: Armand Philippot <59021693+ArmandPhilippot@users.noreply.github.com>
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Co-authored-by: Armand Philippot <59021693+ArmandPhilippot@users.noreply.github.com>
Co-authored-by: Armand Philippot <59021693+ArmandPhilippot@users.noreply.github.com>
Co-authored-by: Armand Philippot <59021693+ArmandPhilippot@users.noreply.github.com>
Co-authored-by: Armand Philippot <59021693+ArmandPhilippot@users.noreply.github.com>
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (required)
Add
reference/api-reference.mdxwith @ArmandPhilippot for the second part.Note
Do not merge now, miss the second part from Armand.Related issues & labels (optional)