Update astro-db.mdx#8478
Merged
sarah11918 merged 5 commits intowithastro:mainfrom Jun 11, 2024
wlai-lp:patch-1
Merged
Conversation
add some missing details to make the tutorial more fluid. if you follow the tutorial, at this point, your comment table has author and content columns. The seed script is going to fail because it's missing data in the author table and the Comment table does not have body column
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
Hello! Thank you for opening your first PR to Astro’s Docs! 🎉 Here’s what will happen next:
|
Contributor
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
sarah11918
reviewed
Jun 10, 2024
Member
sarah11918
left a comment
There was a problem hiding this comment.
Hi @wlai-lp ! Thank you for pointing this out! However, these two examples are not meant to follow each other. This is not a tutorial where you complete every step in order, but just a very minimal example of each process. In fact, none of the examples necessarily work with each other, so that's entirely expected!
I do think your changes are helpful though, for people who are treating it like a tutorial! I will just make a minor change as we like to try to be representative of our global audience when adding new names in our code examples. Thank you again for this contribution, and I am happy to welcome you to Team Docs! 🥳
sarah11918
reviewed
Jun 10, 2024
sarah11918
approved these changes
Jun 10, 2024
Member
|
NOTE: Not merging until we figure out why the deploy build is failing, just to be safe! 😄 (Probably not related to this PR, but want to make sure our builds are working first before merging new PRs) |
thomasbnt
added a commit
to thomasbnt/docs
that referenced
this pull request
Jun 25, 2024
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
yanthomasdev
added a commit
that referenced
this pull request
Jun 25, 2024
* i18n(fr): Update guides/astro-db from #8478 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update guides/backend from #8450 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update guides/backend/google-firebase from #8422 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update guides/cms/apostrophecms from #8480 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update guides/cms/builderio from #8259 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update guides/cms/directus from #8647 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update guides/cms/ghost from #8518 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update guides/cms/statamic from #7119 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update guides/content-collections from #8447 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update guides/data-fetching from #8210 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update guides/deploy/cloudflare from #8421 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update guides/deploy/netlify from #8233 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update guides/deploy/render from #8233 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update guides/deploy/vercel from #8217 (and fix little typos) Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update guides/environment-variables from #8533 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update guides/environment-variables from #8611 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update guides/images from #8447 #8646 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update guides/integrations-guide from #8575 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update guides/integrations-guide/cloudflare from #8211 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update guides/integrations-guide/lit from #8270 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update guides/integrations-guide/markdoc from #8167 (Steeeeps) Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update guides/integrations-guide/preact from #8644 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update guides/integrations-guide/react from #8038 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update guides/integrations-guide/vue from #8295 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update guides/markdown-content from #7218 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update guides/markdown-content from #8167 #8239 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update guides/middleware from #8572 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update guides/prefetch from #8246 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update guides/routing from #8466 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update guides/rss from #8632 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update guides/testing from #8369 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update guides/view-transitions from #8646 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Fix typo in routing.mdx Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Fix links ? Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Fix badge Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Fix badge Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Fix tabs Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Fix tabs Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * Update src/content/docs/fr/guides/environment-variables.mdx Co-authored-by: pioupia <49518790+pioupia@users.noreply.github.com> * Update src/content/docs/fr/guides/integrations-guide/lit.mdx Co-authored-by: pioupia <49518790+pioupia@users.noreply.github.com> * Update src/content/docs/fr/guides/integrations-guide/vue.mdx Co-authored-by: pioupia <49518790+pioupia@users.noreply.github.com> * Update src/content/docs/fr/guides/markdown-content.mdx Co-authored-by: pioupia <49518790+pioupia@users.noreply.github.com> * Update src/content/docs/fr/guides/middleware.mdx Co-authored-by: pioupia <49518790+pioupia@users.noreply.github.com> * Update src/content/docs/fr/guides/testing.mdx Co-authored-by: pioupia <49518790+pioupia@users.noreply.github.com> * Update src/content/docs/fr/guides/testing.mdx Co-authored-by: pioupia <49518790+pioupia@users.noreply.github.com> * Update src/content/docs/fr/guides/testing.mdx Co-authored-by: pioupia <49518790+pioupia@users.noreply.github.com> * i18n(fr): Fix links Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update `tutorial/6-islands` because CI links err Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): fix links Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): fix links Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> --------- Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> Co-authored-by: pioupia <49518790+pioupia@users.noreply.github.com> Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (required)
add some missing details to make the tutorial more fluid. if you follow the tutorial, at this point, your comment table has author and content columns. The seed script is going to fail because it's missing data in the author table and the Comment table does not have body column
Related issues & labels (optional)