Fix service account for firebase prod.#8422
Merged
sarah11918 merged 2 commits intowithastro:mainfrom Jun 14, 2024
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
Member
|
Thank you for looking into this, @leoxs22 ! I'm going to see who I can get to look further into this on our end in case someone has any extra insight before we go ahead and publish this. Hang tight, and thanks for helping! 🙌 |
sarah11918
approved these changes
Jun 14, 2024
Member
sarah11918
left a comment
There was a problem hiding this comment.
OK @leoxs22 , since no one seems to have anything better, and you're confident that this at least doesn't produce an error, I'm going to go with you here and let's get this published and helping people! 🙌
thomasbnt
added a commit
to thomasbnt/docs
that referenced
this pull request
Jun 25, 2024
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
yanthomasdev
added a commit
that referenced
this pull request
Jun 25, 2024
* i18n(fr): Update guides/astro-db from #8478 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update guides/backend from #8450 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update guides/backend/google-firebase from #8422 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update guides/cms/apostrophecms from #8480 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update guides/cms/builderio from #8259 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update guides/cms/directus from #8647 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update guides/cms/ghost from #8518 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update guides/cms/statamic from #7119 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update guides/content-collections from #8447 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update guides/data-fetching from #8210 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update guides/deploy/cloudflare from #8421 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update guides/deploy/netlify from #8233 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update guides/deploy/render from #8233 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update guides/deploy/vercel from #8217 (and fix little typos) Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update guides/environment-variables from #8533 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update guides/environment-variables from #8611 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update guides/images from #8447 #8646 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update guides/integrations-guide from #8575 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update guides/integrations-guide/cloudflare from #8211 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update guides/integrations-guide/lit from #8270 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update guides/integrations-guide/markdoc from #8167 (Steeeeps) Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update guides/integrations-guide/preact from #8644 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update guides/integrations-guide/react from #8038 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update guides/integrations-guide/vue from #8295 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update guides/markdown-content from #7218 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update guides/markdown-content from #8167 #8239 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update guides/middleware from #8572 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update guides/prefetch from #8246 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update guides/routing from #8466 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update guides/rss from #8632 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update guides/testing from #8369 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update guides/view-transitions from #8646 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Fix typo in routing.mdx Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Fix links ? Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Fix badge Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Fix badge Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Fix tabs Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Fix tabs Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * Update src/content/docs/fr/guides/environment-variables.mdx Co-authored-by: pioupia <49518790+pioupia@users.noreply.github.com> * Update src/content/docs/fr/guides/integrations-guide/lit.mdx Co-authored-by: pioupia <49518790+pioupia@users.noreply.github.com> * Update src/content/docs/fr/guides/integrations-guide/vue.mdx Co-authored-by: pioupia <49518790+pioupia@users.noreply.github.com> * Update src/content/docs/fr/guides/markdown-content.mdx Co-authored-by: pioupia <49518790+pioupia@users.noreply.github.com> * Update src/content/docs/fr/guides/middleware.mdx Co-authored-by: pioupia <49518790+pioupia@users.noreply.github.com> * Update src/content/docs/fr/guides/testing.mdx Co-authored-by: pioupia <49518790+pioupia@users.noreply.github.com> * Update src/content/docs/fr/guides/testing.mdx Co-authored-by: pioupia <49518790+pioupia@users.noreply.github.com> * Update src/content/docs/fr/guides/testing.mdx Co-authored-by: pioupia <49518790+pioupia@users.noreply.github.com> * i18n(fr): Fix links Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): Update `tutorial/6-islands` because CI links err Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): fix links Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * i18n(fr): fix links Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> --------- Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> Co-authored-by: pioupia <49518790+pioupia@users.noreply.github.com> Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (required)
The current recommended configuration produces an error when deploying to Firebase. Randomly, the server will return Service unavailable, saying that project_id is undefined when loading the site. After reloading the site a few times it will load, but it will break again after some inactivity (I guess is when firebase shut downs the function) or after a new deploy.
It is pretty random, so it was extremely hard to find what was causing the error. I'm still not sure, but I'm sure this fixes it. My best guess is:
meta.env vars are solved in build time, when running this on a CI, it won't find anything so it will end up as a proccess.env, waiting for the var to be solved in runtime. Firebase already has a default account loaded in every enviroment, so just calling
initializeApp()without anything works perfectly, but the env vars are not available. I'm not sure why after 4 reloads it works, it might be because Firebase loads the env vars but with a delay, or maybe because the app is created with a delay so it ends up ingetApps()In any case, calling the initialize without parameters is the recommended way to initialize it in production, so I would say this is the best approach
(btw, firebase recently released app hosting which seems to be for SSR, I haven't tried it yet, but it might change a lot of things)