fix: prioritize dynamic prerendered routes over dynamic server routes #7235
Merged
MoustaphaDev merged 13 commits intomainfrom May 30, 2023
Merged
fix: prioritize dynamic prerendered routes over dynamic server routes #7235MoustaphaDev merged 13 commits intomainfrom
MoustaphaDev merged 13 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 5a1f8c2 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fix #7200
Currently the ordering conflicts of dynamic static and server routes are resolved alphabetically. However, dynamic static routes should always be prioritized in that case.
Testing
matchAllRoutesfunction to verify that the ordering of matched routes is correctDocs
The current behavior didn't change, but I thought it would be good to add some missing info to the docs
withastro/docs#3374