Elaborate more on the route priority order#3374
Merged
MoustaphaDev merged 7 commits intomainfrom Jun 5, 2023
Merged
Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
MoustaphaDev
commented
May 29, 2023
Comment on lines
+236
to
+251
| 1- Routes without path parameters | ||
| - Endpoints without path parameters take precedence over all other routes | ||
| - Routes without path parameters take precedence over dynamic routes | ||
|
|
||
| - Static routes without path parameters will take precedence over all other routes | ||
| - Dynamic routes using named parameters take precedence over rest parameters | ||
| 2- Dynamic routes with path parameters | ||
| - Static endpoints using named parameters take precedence over other static routes | ||
| - Static routes using named parameters take precedence over server endpoints using named parameters | ||
| - Server endpoints using named parameters take precedence over server routes using named parameters | ||
| - Server routes using named parameters take precedence over other routes using rest parameters | ||
|
|
||
| 3- Dynamic routes with rest parameters | ||
| - Rest parameters have the lowest priority | ||
| - Ties are resolved alphabetically | ||
| - Static endpoints using rest parameters take precedence over other static routes using rest parameters | ||
| - Static routes using rest parameters take precedence over server endpoints using rest parameters | ||
| - Server endpoints using rest parameters take precedence over server routes using rest parameters | ||
| - Server routes using rest parameters take precedence over other routes using rest parameters |
Member
Author
There was a problem hiding this comment.
I wonder if it would be a good idea to create a priority queue or a pyramid component to represent these different cases, I feel like this is a bit hard to follow 😅
Member
|
Sorry, I'm still not at the stage of really editing this yet, but clarifying question: This is now a lot more words to read, and I think really all it's saying new is that in every case, endpoints take priority over routes? Maybe we just need a sentence that says that somewhere, and it applies everywhere? |
Member
Author
|
Yes that, and also prerendered routes take precedence over server routes in dynamic routes (rest and named). |
MoustaphaDev
commented
Jun 1, 2023
sarah11918
reviewed
Jun 3, 2023
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
sarah11918
approved these changes
Jun 5, 2023
Member
sarah11918
left a comment
There was a problem hiding this comment.
Looks great to me! Thanks for this! 🚀
MoustaphaDev
commented
Jun 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of changes does this PR include?
Description
The current route priority order section lacks some info. For example, endpoints always take precedence in their route category, and prerendered routes always take precedence over server routes. This PR adds more about all that.