Fixes assetQueryParams and public folder tests#14853
Merged
matthewp merged 8 commits intofeat/environment-apifrom Nov 21, 2025
Merged
Fixes assetQueryParams and public folder tests#14853matthewp merged 8 commits intofeat/environment-apifrom
matthewp merged 8 commits intofeat/environment-apifrom
Conversation
Encoding now works the same in static and ssr mode. Since this is not supported in SSR its also not done so in static.
|
matthewp
commented
Nov 21, 2025
| assert.equal($('.category').text(), '%3Fsomething'); | ||
| }); | ||
|
|
||
| it("It doesn't encode/decode URI characters such as %25 (%)", async () => { |
Contributor
Author
There was a problem hiding this comment.
This is removed because we can no longer support this. The reason this worked before was we used the result of getStaticPaths during static builds directly. Now we produce paths and send the requests through app.render(request), so the params are in the URL. Those params get decoded for security reasons which we fixed in GHSA-hr2q-hp5q-x767
These are not encoded in SSR so they no longer can be in static.
Member
There was a problem hiding this comment.
This requires a major changeset, with a thorough explanation of why we can't support this anymore. Worth adding a ticket for that
Contributor
Author
There was a problem hiding this comment.
Added an issue to the board
ematipico
reviewed
Nov 21, 2025
| assert.equal($('.category').text(), '%3Fsomething'); | ||
| }); | ||
|
|
||
| it("It doesn't encode/decode URI characters such as %25 (%)", async () => { |
Member
There was a problem hiding this comment.
This requires a major changeset, with a thorough explanation of why we can't support this anymore. Worth adding a ticket for that
ematipico
approved these changes
Nov 21, 2025
ematipico
added a commit
that referenced
this pull request
Dec 4, 2025
Co-authored-by: Emanuele Stoppa <my.burning@gmail.com> Co-authored-by: Samuel Macleod <smacleod@cloudflare.com> Co-authored-by: Alexander Niebuhr <alexander@nbhr.io> Co-authored-by: ascorbic <213306+ascorbic@users.noreply.github.com> Co-authored-by: matthewp <361671+matthewp@users.noreply.github.com> Co-authored-by: Florian Lefebvre <contact@florian-lefebvre.dev> Co-authored-by: Matt Kane <m@mk.gg> Co-authored-by: florian-lefebvre <69633530+florian-lefebvre@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: Matthew Phillips <matthew@skypack.dev> Co-authored-by: Matthew Phillips <matthew@skypack.dev> Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com> Co-authored-by: Erika <3019731+Princesseuh@users.noreply.github.com> Co-authored-by: Hayato Hasegawa <hase1225hayato@gmail.com> fix: creation of routes list in build (#14325) Fix unit tests for environment API (#14394) fixture (#14599) fix: organize imports and formatting in cloudflare handler (#14697) fix: resolve environment-api build issues for client & CSS (#14770) Fixes CSS when both static/client styles exist (#14790) fix: flag `serverLike` incorrectly computed (#14792) fix: redirects and i18n routing (#14797) fix: logger level and static paths params (#14799) Fix image tests crashing (#14803) fix(environment): Error overlay not working (#14816) fix: hashing of chunks (#14811) Fix before-hydration script emission for environment-api (#14818) fix: node leak into content collections (#14820) fix: avoid `node:path` (#14827) Fix API route tests (#14825) Fix unit tests (#14832) fix: server islands build (#14830) Fix astro-component-bundling tests (#14840) Fix astro-component-bundling tests (#14837) Fix config alias by using resolve.alias config (#14828) fix: container and routing tests (#14852) fix: respect user vite config on sourcemaps (#14847) fix: remove useless tests (#14854) Fixes assetQueryParams and public folder tests (#14853) fix: renderError fallback (#14855) Fix server-islands data being used across tests (#14857) fix: incorrect configuration in tests (#14858) Fixes for tests in environment branch (#14865) Fixes for e2e tests in environment branch (#14870) fix(test): svelte async rendering (#14886) fix(cloudflare/vercel/netlify): some tests pass and excluded others (#14892) Fixes for node integrations tests (#14900) Fix @astrojs/db tests (#14899) fix(environment): Prevent Vite from interpreting injected sourcemap comments as actual sourcemaps (#14921) Fix remaining cloudflare tests (#14912) fix(vite): import mergeConfig from direct file to avoid dynamic import being processed by Vite (#14939) Fix astro:env tests in Cloudflare (#14925)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This fixes 2 different issues:
public/folder during the client build.Testing
packages/astro/test/asset-query-params.test.jspackages/astro/test/static-build.test.jspackages/astro/test/params.test.jspackages/astro/test/astro-pageDirectoryUrl.test.jsDocs
N/A