-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Infinite loop when middleware creates a 404 response #10735
Copy link
Copy link
Closed
Labels
- P5: urgentFix build-breaking bugs affecting most users, should be released ASAP (priority)Fix build-breaking bugs affecting most users, should be released ASAP (priority)feat: error pagesRelated to 404 and 500 handling (scope)Related to 404 and 500 handling (scope)feat: middlewareRelated to middleware (scope)Related to middleware (scope)regression
Metadata
Metadata
Assignees
Labels
- P5: urgentFix build-breaking bugs affecting most users, should be released ASAP (priority)Fix build-breaking bugs affecting most users, should be released ASAP (priority)feat: error pagesRelated to 404 and 500 handling (scope)Related to 404 and 500 handling (scope)feat: middlewareRelated to middleware (scope)Related to middleware (scope)regression
Astro Info
If this issue only occurs in one browser, which browser is a problem?
No response
Describe the Bug
Quoting #8100 (comment)
What's the expected result?
Server does NOT recursively call itself. Context: "Recursive rerouting" section of withastro/roadmap#681.
Link to Minimal Reproducible Example
astro/packages/astro/test/fixtures/custom-404-loop-case-3/src/middleware.js
Line 4 in 2acea4d
astro/packages/astro/test/custom-404-implicit-rerouting.test.js
Lines 35 to 36 in 2acea4d
Participation