chore: Migrate all packages/create-astro/test to node:test#10084
chore: Migrate all packages/create-astro/test to node:test#10084ematipico merged 15 commits intowithastro:mainfrom
packages/create-astro/test to node:test#10084Conversation
|
|
|
||
| expect(context.cwd).to.eq('./foo/bar/baz'); | ||
| expect(context.projectName).to.eq('baz'); | ||
| assert.strictEqual(context.cwd, './foo/bar/baz'); |
There was a problem hiding this comment.
assert.equal and assert.strictEqual are the same because we import node:assert/strict. Can we use assert.equal like we are doing in the rest of the code base?
There was a problem hiding this comment.
hey, yeah you're right, .equal will be better as it maintains the consistancy through out the codebase. Give me a minute I'll update this.
4ad1bc0 to
1b528d2
Compare
…ithub.com/shoaibkh4n/astro into shoaibkh4n/testing_migration_create_astro
|
Hey @ematipico , there is a problem with the nodejs test runner, sometimes it just stuck and lead to timeout. Even I made the description async with a low nesting. Any idea Why thou? |
No idea, let's see if the concurrency testing allows us to see which test times out and why (I just pushed a commit in your PR) |
|
I noticed the problem after |
Changes
Migrates all mocha tests to node:test of
packages/create-astro/testPart of ☂️ Move Astro tests to node:test #9873
Testing
All tests passed!
Docs
No docs added as this only affects testing.