Closed
Conversation
added 3 commits
March 24, 2026 09:43
Contributor
There was a problem hiding this comment.
2 issues found across 1 file
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/integrations/mpris/index.ts">
<violation number="1" location="src/integrations/mpris/index.ts:620">
P1: Async artwork caching can apply stale track metadata out of order, causing MPRIS state to regress to an older track.</violation>
<violation number="2" location="src/integrations/mpris/index.ts:651">
P2: Artwork caching download path lacks timeout and stream-error fallback, so metadata updates can hang when transfer/write never reaches `finish`.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| schedulePropertyEmission({ Metadata: metadata }); | ||
| const setMetadata = () => { | ||
| if (playerIfaceRef) { | ||
| playerIfaceRef._metadata = metadata; |
Contributor
There was a problem hiding this comment.
P1: Async artwork caching can apply stale track metadata out of order, causing MPRIS state to regress to an older track.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At src/integrations/mpris/index.ts, line 620:
<comment>Async artwork caching can apply stale track metadata out of order, causing MPRIS state to regress to an older track.</comment>
<file context>
@@ -609,14 +615,62 @@ function onNowPlayingItemDidChange(payload: unknown): void {
- schedulePropertyEmission({ Metadata: metadata });
+ const setMetadata = () => {
+ if (playerIfaceRef) {
+ playerIfaceRef._metadata = metadata;
+ playerIfaceRef._currentTrackId = trackId;
+ playerIfaceRef._position = 0;
</file context>
| https.get(p.artworkUrl as string, (res: any) => { | ||
| if (res.statusCode === 200) { | ||
| const stream = createWriteStream(filepath); | ||
| res.pipe(stream); |
Contributor
There was a problem hiding this comment.
P2: Artwork caching download path lacks timeout and stream-error fallback, so metadata updates can hang when transfer/write never reaches finish.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At src/integrations/mpris/index.ts, line 651:
<comment>Artwork caching download path lacks timeout and stream-error fallback, so metadata updates can hang when transfer/write never reaches `finish`.</comment>
<file context>
@@ -609,14 +615,62 @@ function onNowPlayingItemDidChange(payload: unknown): void {
+ https.get(p.artworkUrl as string, (res: any) => {
+ if (res.statusCode === 200) {
+ const stream = createWriteStream(filepath);
+ res.pipe(stream);
+ stream.on('finish', () => {
+ stream.close();
</file context>
flexiondotorg
added a commit
that referenced
this pull request
Mar 25, 2026
#39 - Add artwork module with downloadArtwork() to cache remote HTTPS URLs - Store artwork locally with content-addressable naming (SHA-256 hashing) - Emit file:// URIs from MPRIS integration (required for GNOME Shell) - Provide local file paths to desktop notifications for display - Implement automatic cache cleanup on app startup (7-day retention) - Prevent unbounded cache growth in ~/.cache/sidra/artwork/ Signed-off-by: Martin Wimpress <code@wimpress.io>
flexiondotorg
added a commit
that referenced
this pull request
Mar 25, 2026
#39 - Add artwork module with downloadArtwork() to cache remote HTTPS URLs - Store artwork locally with content-addressable naming (SHA-256 hashing) - Emit file:// URIs from MPRIS integration (required for GNOME Shell) - Provide local file paths to desktop notifications for display - Implement automatic cache cleanup on app startup (7-day retention) - Prevent unbounded cache growth in ~/.cache/sidra/artwork/ Signed-off-by: Martin Wimpress <code@wimpress.io>
Member
|
Fixed via 9939cfe |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This Pull Request builds upon the newly introduced local caching mechanism to address a prominent optimization bug in highly restrictive desktop environments like GNOME Shell.
GNOME Shell contains an aggressive memory optimization behavior where it flat-out ignores subsequent D-Bus metadata updates if the
mpris:trackidremains unchanged. Since downloading the local artwork takes ~500ms, the previous implementation would emit the track change immediately, making GNOME ignore the subsequentfile://artwork update arriving milliseconds later.Reference: #33