Closed
Conversation
Contributor
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/integrations/mpris/index.ts">
<violation number="1" location="src/integrations/mpris/index.ts:642">
P1: Asynchronous artwork-cache callbacks can overwrite newer track metadata because they update `_metadata` without verifying the track is still current.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| .then(() => { | ||
| metadata['mpris:artUrl'] = new Variant('s', fileUrl); | ||
| if (playerIfaceRef) { | ||
| playerIfaceRef._metadata = metadata; |
Contributor
There was a problem hiding this comment.
P1: Asynchronous artwork-cache callbacks can overwrite newer track metadata because they update _metadata without verifying the track is still current.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At src/integrations/mpris/index.ts, line 642:
<comment>Asynchronous artwork-cache callbacks can overwrite newer track metadata because they update `_metadata` without verifying the track is still current.</comment>
<file context>
@@ -617,6 +623,51 @@ function onNowPlayingItemDidChange(payload: unknown): void {
+ .then(() => {
+ metadata['mpris:artUrl'] = new Variant('s', fileUrl);
+ if (playerIfaceRef) {
+ playerIfaceRef._metadata = metadata;
+ schedulePropertyEmission({ Metadata: metadata });
+ }
</file context>
flexiondotorg
added a commit
that referenced
this pull request
Mar 25, 2026
#39 - Add artwork module with downloadArtwork() to cache remote HTTPS URLs - Store artwork locally with content-addressable naming (SHA-256 hashing) - Emit file:// URIs from MPRIS integration (required for GNOME Shell) - Provide local file paths to desktop notifications for display - Implement automatic cache cleanup on app startup (7-day retention) - Prevent unbounded cache growth in ~/.cache/sidra/artwork/ Signed-off-by: Martin Wimpress <code@wimpress.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Many Linux desktop environments (most notably GNOME's built-in media controls) deliberately reject remote
https://URLs in MPRIS payloads for security and rendering performance reasons.This Pull Request implements asynchronous downloading of the artwork from the remote Apple CDN to a universally readable local path (
app.getPath('userData')/art, which evaluates to~/.config/sidra/art). UsinguserDataoveros.tmpDiror AppImage's sandboxedcacheensures the host OS can successfully traverse and read the cached image path across all distribution methods.The original
https://URL is still emitted immediately as a fallback for more tolerant environments like KDE Plasma, but updates to a compliantfile:///...URI once the local JPG is ready.Reference: #33