[CMS PR 25559] Add list of folders to keep on update#69
Merged
wilsonge merged 3 commits intowilsonge:deleted_file_reworkfrom Jul 2, 2021
Conversation
Owner
|
I know i merged the original PR. but i guess I missed it when I merged. |
Author
|
Then it seems you really had missed that discussion. Will provide fix here soon ... and for the CMS I would have to add it back to script.php. |
Author
|
Ok, fixed. |
Author
Ah, now I see: You commented, but it was not clear to me that it means that the libraries/vendor/bin should be reverted. And at the end you merged it. |
Author
|
CMS PR see joomla#34638 . |
wilsonge
pushed a commit
that referenced
this pull request
Jul 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for joomla#25559 .
Summary of Changes
Make sure we don't delete certain folders on update even if we deleted everything inside them, as long as we don't have a "Folder::DeleteIfEmpty" in the framework's filesystem package.
Currently these are the
/binand/libraries/vendor/binfolders, see also joomla#34289 .Testing Instructions
Use your tool with and without this PR and compare the difference between the results.
The only difference is that the 2 folders mentioned above are missing in the list of folders to be deleted.