[4.0] Add back "/libraries/vendor/bin" to folder deletion in script.php#34638
Merged
wilsonge merged 1 commit intojoomla:4.0-devfrom Jun 29, 2021
Conversation
Member
|
I have tested this item ✅ successfully on cbb7e62 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34638. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on cbb7e62 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34638. |
Member
Author
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34638. |
Contributor
|
Thanks! |
Member
Author
|
Thanks all. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for wilsonge#69 (comment) .
Summary of Changes
With PR #34289 folders
/binand/libraries/vendor/binhave been removed from the list of folders to be deleted on update in script.php because these folders might contain files or subfolders added by the site admin.For
/libraries/vendor/binthis was wrong because that folder is maintained by composer and completely cleared on the development environment when doing a composer install.See also the comment here wilsonge#69 (comment) .
This PR here corrects this by adding that folder back.
As that folder has been removed from the installation and update packages with 4.0 RC 1, the folder is added back to section
4.0 from Beta 7 to RC 1like it was before PR #34289 .Testing Instructions
Code review.
Actual result BEFORE applying this Pull Request
No folder
/libraries/vendor/binin section4.0 from Beta 7 to RC 1of the$foldersarray in methoddeleteUnexistingFilesof fileadministrator/components/com_admin/script.php.Expected result AFTER applying this Pull Request
Folder
/libraries/vendor/binin section4.0 from Beta 7 to RC 1of the$foldersarray in methoddeleteUnexistingFilesof fileadministrator/components/com_admin/script.php.Hint: Folders within a version specific section are ordered reverse alphabetical.
Documentation Changes Required
None.