Remove <label form> and redefine label.form IDL attribute#1120
Merged
Conversation
|
|
||
| </dd> | ||
|
|
||
| </dl> |
Member
There was a problem hiding this comment.
Should this perhaps be higher up? Usually the domintro is before we describe any IDL attributes.
Member
|
LGTM, should we wait for two implementer commitments? |
Member
Author
|
Seems like we can go ahead with this. Need tests though, web-platform-tests/wpt#2924 |
zcorpan
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Apr 29, 2016
This was referenced Apr 29, 2016
zcorpan
added a commit
to web-platform-tests/wpt
that referenced
this pull request
May 13, 2016
arronei
pushed a commit
to arronei/web-platform-tests
that referenced
this pull request
Jun 14, 2016
…ec change (web-platform-tests#2926) This tests whatwg/html#1120.
ivanzr
pushed a commit
to ivanzr/web-platform-tests
that referenced
this pull request
Jun 29, 2016
…ec change (web-platform-tests#2926) This tests whatwg/html#1120.
cscott
added a commit
to fgnass/domino
that referenced
this pull request
Oct 14, 2016
This fixes a test case which was broken by c8fbfff. The upstream removal of the form attribute for <label> was whatwg/html#787, pulled in whatwg/html#1120, and implemented in browsers as whatwg/html#787 (comment).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements #787 (comment)
Separated into several commits for easier reviewing.