Fix #2924: Update tests for <label form> removal spec change#2926
Merged
Conversation
|
Critic review: https://critic.hoppipolla.co.uk/r/6456 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
Collaborator
|
Reviewers for this pull request are: @Ms2ger, @ayg, @gsnedders, @jdm, @jgraham, @plehegar, @sideshowbarker, @zcorpan, and @zqzhang. |
| <p><label id="label-form-form2" form="form2">label-form-form2</label> | ||
| <p><label id="label-with-control">label-with-control <input></label> | ||
| <p><label id="label-for" for="control-for-label">label-for</label> <input id="control-for-label"> | ||
| </form> |
Member
There was a problem hiding this comment.
We should add one more here with a label pointing to an input that has a form attribute which points to form2. It's sort of tested by "form2" below, but there the control is not nested inside another form.
Member
|
LGTM % nit. |
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
May 26, 2016
…e. r=bkelly,hsivonen,surkov The web platform tests changes are just a cherrypick of web-platform-tests/wpt#2926 so I don't have to add failure annotations until the next test uplift. I've audited our uses of nsIFormControl, and this patch looks to me like it preserves existing behavior in all but the following cases: 1) nsXBLPrototypeHandler::DispatchXBLCommand, the case of scrolling when space is pressed while something inside a <label> is focused. We used to not scroll in this situation; I think this is a bug, so I'm changing that behavior to scroll instead. 2) In Accessible::RelationByType for the RelationType::DEFAULT_BUTTON case, when mContent is a <label> we used to return its form's default submit element. Now we will just return Relation().
josyeh
pushed a commit
to josyeh/gecko
that referenced
this pull request
May 30, 2016
…e. r=bkelly,hsivonen,surkov The web platform tests changes are just a cherrypick of web-platform-tests/wpt#2926 so I don't have to add failure annotations until the next test uplift. I've audited our uses of nsIFormControl, and this patch looks to me like it preserves existing behavior in all but the following cases: 1) nsXBLPrototypeHandler::DispatchXBLCommand, the case of scrolling when space is pressed while something inside a <label> is focused. We used to not scroll in this situation; I think this is a bug, so I'm changing that behavior to scroll instead. 2) In Accessible::RelationByType for the RelationType::DEFAULT_BUTTON case, when mContent is a <label> we used to return its form's default submit element. Now we will just return Relation().
jryans
pushed a commit
to jryans/gecko-dev
that referenced
this pull request
Jun 1, 2016
…e. r=bkelly,hsivonen,surkov The web platform tests changes are just a cherrypick of web-platform-tests/wpt#2926 so I don't have to add failure annotations until the next test uplift. I've audited our uses of nsIFormControl, and this patch looks to me like it preserves existing behavior in all but the following cases: 1) nsXBLPrototypeHandler::DispatchXBLCommand, the case of scrolling when space is pressed while something inside a <label> is focused. We used to not scroll in this situation; I think this is a bug, so I'm changing that behavior to scroll instead. 2) In Accessible::RelationByType for the RelationType::DEFAULT_BUTTON case, when mContent is a <label> we used to return its form's default submit element. Now we will just return Relation().
arronei
pushed a commit
to arronei/web-platform-tests
that referenced
this pull request
Jun 14, 2016
…ec change (web-platform-tests#2926) This tests whatwg/html#1120.
ivanzr
pushed a commit
to ivanzr/web-platform-tests
that referenced
this pull request
Jun 29, 2016
…ec change (web-platform-tests#2926) This tests whatwg/html#1120.
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Sep 30, 2019
…e. r=bkelly,hsivonen,surkov The web platform tests changes are just a cherrypick of web-platform-tests/wpt#2926 so I don't have to add failure annotations until the next test uplift. I've audited our uses of nsIFormControl, and this patch looks to me like it preserves existing behavior in all but the following cases: 1) nsXBLPrototypeHandler::DispatchXBLCommand, the case of scrolling when space is pressed while something inside a <label> is focused. We used to not scroll in this situation; I think this is a bug, so I'm changing that behavior to scroll instead. 2) In Accessible::RelationByType for the RelationType::DEFAULT_BUTTON case, when mContent is a <label> we used to return its form's default submit element. Now we will just return Relation(). UltraBlame original commit: c4bde82ab5934ff314072d653abd983579ea0d23
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Sep 30, 2019
…e. r=bkelly,hsivonen,surkov The web platform tests changes are just a cherrypick of web-platform-tests/wpt#2926 so I don't have to add failure annotations until the next test uplift. I've audited our uses of nsIFormControl, and this patch looks to me like it preserves existing behavior in all but the following cases: 1) nsXBLPrototypeHandler::DispatchXBLCommand, the case of scrolling when space is pressed while something inside a <label> is focused. We used to not scroll in this situation; I think this is a bug, so I'm changing that behavior to scroll instead. 2) In Accessible::RelationByType for the RelationType::DEFAULT_BUTTON case, when mContent is a <label> we used to return its form's default submit element. Now we will just return Relation(). UltraBlame original commit: c4bde82ab5934ff314072d653abd983579ea0d23
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Sep 30, 2019
…e. r=bkelly,hsivonen,surkov The web platform tests changes are just a cherrypick of web-platform-tests/wpt#2926 so I don't have to add failure annotations until the next test uplift. I've audited our uses of nsIFormControl, and this patch looks to me like it preserves existing behavior in all but the following cases: 1) nsXBLPrototypeHandler::DispatchXBLCommand, the case of scrolling when space is pressed while something inside a <label> is focused. We used to not scroll in this situation; I think this is a bug, so I'm changing that behavior to scroll instead. 2) In Accessible::RelationByType for the RelationType::DEFAULT_BUTTON case, when mContent is a <label> we used to return its form's default submit element. Now we will just return Relation(). UltraBlame original commit: c4bde82ab5934ff314072d653abd983579ea0d23
rmottola
added a commit
to rmottola/Arctic-Fox
that referenced
this pull request
Dec 2, 2024
…e. r=bkelly,hsivonen,surkov The web platform tests changes are just a cherrypick of web-platform-tests/wpt#2926 so I don't have to add failure annotations until the next test uplift. I've audited our uses of nsIFormControl, and this patch looks to me like it preserves existing behavior in all but the following cases: 1) nsXBLPrototypeHandler::DispatchXBLCommand, the case of scrolling when space is pressed while something inside a <label> is focused. We used to not scroll in this situation; I think this is a bug, so I'm changing that behavior to scroll instead. 2) In Accessible::RelationByType for the RelationType::DEFAULT_BUTTON case, when mContent is a <label> we used to return its form's default submit element. Now we will just return Relation().
sergiotarxz
pushed a commit
to sergiotarxz/JapacharBrowser
that referenced
this pull request
Mar 22, 2026
…e. r=bkelly,hsivonen,surkov The web platform tests changes are just a cherrypick of web-platform-tests/wpt#2926 so I don't have to add failure annotations until the next test uplift. I've audited our uses of nsIFormControl, and this patch looks to me like it preserves existing behavior in all but the following cases: 1) nsXBLPrototypeHandler::DispatchXBLCommand, the case of scrolling when space is pressed while something inside a <label> is focused. We used to not scroll in this situation; I think this is a bug, so I'm changing that behavior to scroll instead. 2) In Accessible::RelationByType for the RelationType::DEFAULT_BUTTON case, when mContent is a <label> we used to return its form's default submit element. Now we will just return Relation().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tests whatwg/html#1120.
Issue: #2924
cc @tkent-google