Add ToggleEvent.source by josepharhar · Pull Request #11186 · whatwg/html

josepharhar · 2025-04-02T23:06:22Z

This adds a new Element attribute to ToggleEvent called source. The ToggleEvent's source attribute is set to the element which invoked the element which the ToggleEvent is being fired on. Sources can be set up as a parameter passed to element.showPopover(), an element with the popovertarget attribute, or an element with the commandfor attribute.

Fixes #9111

At least two implementers are interested (and none opposed):
- Chromium
- Gecko: ToggleEvent source attribute mozilla/standards-positions#1220
- WebKit: ToggleEvent source attribute WebKit/standards-positions#494
Tests are written and can be reviewed and commented upon at:
- Implement ToggleEvent.source web-platform-tests/wpt#52589
Implementation bugs are filed:
- Chromium: https://issues.chromium.org/issues/408018828
- Gecko: https://bugzilla.mozilla.org/show_bug.cgi?id=1968987
- WebKit: https://bugs.webkit.org/show_bug.cgi?id=293686
Corresponding HTML AAM & ARIA in HTML issues & PRs: I don't think this needs any ARIA/AAM stuff.
MDN issue is filed: ToggleEvent.source mdn/content#39723
The top of this comment includes a clear commit message to use.

(See WHATWG Working Mode: Changes for more details.)

/form-control-infrastructure.html ( diff )
/form-elements.html ( diff )
/infrastructure.html ( diff )
/interaction.html ( diff )
/interactive-elements.html ( diff )
/popover.html ( diff )

This adds a new Element attribute to ToggleEvent called invoker. The ToggleEvent's invoker attribute is set to the element which invoked the element which the ToggleEvent is being fired on. Invokers can be set up as a parameter passed to element.showPopover(), an element with the popovertarget attribute, or an element with the commandfor attribute. Fixes whatwg#9111

domenic · 2025-04-03T00:38:26Z

I haven't kept up with all the command discussions, but didn't we decide never to use the word "invoker" in the public APIs? (I've been a bit disappointed to see it popping up in documentation given that decision, but that's a separate thing...)

I thought we settled on source in CommandEvent.

nt1m · 2025-04-03T04:43:04Z

source is also what's used for the imperative API: showPopover({source: ...})

josepharhar · 2025-04-03T15:58:50Z

Thank you both! I renamed it from invoker to source.

keithamus

Generally this looks good, and I think it is well motivated. I've done what I'll call a "pseudo editorial review pass" and by my eyes this has no editorial issues.

Some meta commentary that's perhaps worth pointing out: details elements toggling, and dialog.show()/showModal(), all dispatch toggle events where the source will be null. I think that's a little odd, and maybe worth discussing, but I don't see it as problematic to change in a follow-up, or possibly never. For example it might be nice to later add {source} as an argument to show()/showModal().

josepharhar · 2025-04-23T19:26:11Z

Thanks Keith!

If command invokers make it possible to declaratively toggle a details element in the future, we could make the command attribute invoker element get set as the source of the toggle event. We could also use the summary element as Luke mentioned in the issue thread if that seems valuable, hopefully that's not too hard to spec.

Adding a source argument to show()/showModal() makes sense, but since that argument already does more for popovers I'm not sure that this change alone justifies adding that as a parameter to those methods. If an invoker/source argument is ever added though, we should add it as the source of the toggle event.

domenic

Generally looks good, but ~~I think we can do the events better~~Nope, we can't, I was wrong.

Also, I haven't yet done a final check that all updated algorithms match all their call sites. It looks likely that you got them all, but if you want to double-check that could save us some time.

josepharhar · 2025-05-29T21:16:14Z

Also, I haven't yet done a final check that all updated algorithms match all their call sites. It looks likely that you got them all, but if you want to double-check that could save us some time.

I just double checked and fixed two of them

I recently added this to the spec PR after incorporating spec changes for the addition of dialog.requestClose: whatwg/html#11186 Bug: 4080188 Change-Id: Ia6a3a2560349760219a863dba814c5addfa60165 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6598554 Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1468857}

The spec PR has been merged, so these WPTs should no longer be marked as tentative: whatwg/html#11186 Bug: 408018828 Change-Id: I6ff9da8ab80551cdb4cae3cfca3cb60872806dfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6621684 Reviewed-by: Luke <lwarlow@igalia.com> Commit-Queue: Luke <lwarlow@igalia.com> Cr-Commit-Position: refs/heads/main@{#1469501}

The spec PR has been merged, so these WPTs should no longer be marked as tentative: whatwg/html#11186 Bug: 4080188 Change-Id: I6ff9da8ab80551cdb4cae3cfca3cb60872806dfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6621684 Reviewed-by: Luke <lwarlow@igalia.com> Commit-Queue: Luke <lwarlow@igalia.com> Cr-Commit-Position: refs/heads/main@{#1469501}

See: whatwg/html#11186

…requestclose, a=testonly Automatic update from web-platform-tests Implement ToggleEvent.source for dialog requestclose I recently added this to the spec PR after incorporating spec changes for the addition of dialog.requestClose: whatwg/html#11186 Bug: 408018828 Change-Id: Ia6a3a2560349760219a863dba814c5addfa60165 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6598554 Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1468857} -- wpt-commits: 4f0e0581b96db8b8cb82c1ca74ee08e47225fed0 wpt-pr: 52935

…ve, a=testonly Automatic update from web-platform-tests Make ToggleEvent.source WPTs non-tentative The spec PR has been merged, so these WPTs should no longer be marked as tentative: whatwg/html#11186 Bug: 408018828 Change-Id: I6ff9da8ab80551cdb4cae3cfca3cb60872806dfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6621684 Reviewed-by: Luke <lwarlow@igalia.com> Commit-Queue: Luke <lwarlow@igalia.com> Cr-Commit-Position: refs/heads/main@{#1469501} -- wpt-commits: 70f0a19eac6b582538f523fdfe19fced1b6b4e1f wpt-pr: 52967

…requestclose, a=testonly Automatic update from web-platform-tests Implement ToggleEvent.source for dialog requestclose I recently added this to the spec PR after incorporating spec changes for the addition of dialog.requestClose: whatwg/html#11186 Bug: 408018828 Change-Id: Ia6a3a2560349760219a863dba814c5addfa60165 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6598554 Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1468857} -- wpt-commits: 4f0e0581b96db8b8cb82c1ca74ee08e47225fed0 wpt-pr: 52935

…ve, a=testonly Automatic update from web-platform-tests Make ToggleEvent.source WPTs non-tentative The spec PR has been merged, so these WPTs should no longer be marked as tentative: whatwg/html#11186 Bug: 408018828 Change-Id: I6ff9da8ab80551cdb4cae3cfca3cb60872806dfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6621684 Reviewed-by: Luke <lwarlow@igalia.com> Commit-Queue: Luke <lwarlow@igalia.com> Cr-Commit-Position: refs/heads/main@{#1469501} -- wpt-commits: 70f0a19eac6b582538f523fdfe19fced1b6b4e1f wpt-pr: 52967

…requestclose, a=testonly Automatic update from web-platform-tests Implement ToggleEvent.source for dialog requestclose I recently added this to the spec PR after incorporating spec changes for the addition of dialog.requestClose: whatwg/html#11186 Bug: 408018828 Change-Id: Ia6a3a2560349760219a863dba814c5addfa60165 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6598554 Reviewed-by: Mason Freed <masonfchromium.org> Commit-Queue: Joey Arhar <jarharchromium.org> Cr-Commit-Position: refs/heads/main{#1468857} -- wpt-commits: 4f0e0581b96db8b8cb82c1ca74ee08e47225fed0 wpt-pr: 52935 UltraBlame original commit: 3d3513ffa8b83bb57598a1baf6a00479b4178660

…ve, a=testonly Automatic update from web-platform-tests Make ToggleEvent.source WPTs non-tentative The spec PR has been merged, so these WPTs should no longer be marked as tentative: whatwg/html#11186 Bug: 408018828 Change-Id: I6ff9da8ab80551cdb4cae3cfca3cb60872806dfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6621684 Reviewed-by: Luke <lwarlowigalia.com> Commit-Queue: Luke <lwarlowigalia.com> Cr-Commit-Position: refs/heads/main{#1469501} -- wpt-commits: 70f0a19eac6b582538f523fdfe19fced1b6b4e1f wpt-pr: 52967 UltraBlame original commit: 3adec0711c8851da2c80a50466b7e2527d4dd8d4

…requestclose, a=testonly Automatic update from web-platform-tests Implement ToggleEvent.source for dialog requestclose I recently added this to the spec PR after incorporating spec changes for the addition of dialog.requestClose: whatwg/html#11186 Bug: 408018828 Change-Id: Ia6a3a2560349760219a863dba814c5addfa60165 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6598554 Reviewed-by: Mason Freed <masonfchromium.org> Commit-Queue: Joey Arhar <jarharchromium.org> Cr-Commit-Position: refs/heads/main{#1468857} -- wpt-commits: 4f0e0581b96db8b8cb82c1ca74ee08e47225fed0 wpt-pr: 52935 UltraBlame original commit: 3d3513ffa8b83bb57598a1baf6a00479b4178660

…ve, a=testonly Automatic update from web-platform-tests Make ToggleEvent.source WPTs non-tentative The spec PR has been merged, so these WPTs should no longer be marked as tentative: whatwg/html#11186 Bug: 408018828 Change-Id: I6ff9da8ab80551cdb4cae3cfca3cb60872806dfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6621684 Reviewed-by: Luke <lwarlowigalia.com> Commit-Queue: Luke <lwarlowigalia.com> Cr-Commit-Position: refs/heads/main{#1469501} -- wpt-commits: 70f0a19eac6b582538f523fdfe19fced1b6b4e1f wpt-pr: 52967 UltraBlame original commit: 3adec0711c8851da2c80a50466b7e2527d4dd8d4

…requestclose, a=testonly Automatic update from web-platform-tests Implement ToggleEvent.source for dialog requestclose I recently added this to the spec PR after incorporating spec changes for the addition of dialog.requestClose: whatwg/html#11186 Bug: 408018828 Change-Id: Ia6a3a2560349760219a863dba814c5addfa60165 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6598554 Reviewed-by: Mason Freed <masonfchromium.org> Commit-Queue: Joey Arhar <jarharchromium.org> Cr-Commit-Position: refs/heads/main{#1468857} -- wpt-commits: 4f0e0581b96db8b8cb82c1ca74ee08e47225fed0 wpt-pr: 52935 UltraBlame original commit: 3d3513ffa8b83bb57598a1baf6a00479b4178660

…ve, a=testonly Automatic update from web-platform-tests Make ToggleEvent.source WPTs non-tentative The spec PR has been merged, so these WPTs should no longer be marked as tentative: whatwg/html#11186 Bug: 408018828 Change-Id: I6ff9da8ab80551cdb4cae3cfca3cb60872806dfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6621684 Reviewed-by: Luke <lwarlowigalia.com> Commit-Queue: Luke <lwarlowigalia.com> Cr-Commit-Position: refs/heads/main{#1469501} -- wpt-commits: 70f0a19eac6b582538f523fdfe19fced1b6b4e1f wpt-pr: 52967 UltraBlame original commit: 3adec0711c8851da2c80a50466b7e2527d4dd8d4

josepharhar mentioned this pull request Apr 2, 2025

Popover does not know what triggered it #9111

Closed

rename invoker to source

2703548

josepharhar changed the title ~~Add ToggleEvent.invoker~~ Add ToggleEvent.source Apr 3, 2025

annevk added needs implementer interest Moving the issue forward requires implementers to express interest needs tests Moving the issue forward requires someone to write tests labels Apr 4, 2025

josepharhar added 2 commits April 22, 2025 14:57

Merge branch 'main' into toggleinvoker

74bbfcc

Add invoker parameter to hide popover algorithm

b3331a6

keithamus approved these changes Apr 23, 2025

View reviewed changes

josepharhar mentioned this pull request May 1, 2025

ToggleEvent source attribute mozilla/standards-positions#1220

Closed

josepharhar mentioned this pull request May 12, 2025

ToggleEvent source attribute WebKit/standards-positions#494

Closed

josepharhar mentioned this pull request May 28, 2025

ToggleEvent.source mdn/content#39723

Closed

Merge remote-tracking branch 'upstream/main' into toggleinvoker

0f0b19a

domenic reviewed May 29, 2025

View reviewed changes

Comment thread source Outdated

Comment thread source Outdated

Comment thread source Outdated

Comment thread source Outdated

Comment thread source Outdated

Comment thread source

Comment thread source Outdated

josepharhar added 2 commits May 29, 2025 10:38

address comments

f88886b

fix missing parameters

88438af

annevk added addition/proposal New features or enhancements topic: events and removed needs implementer interest Moving the issue forward requires implementers to express interest needs tests Moving the issue forward requires someone to write tests labels May 29, 2025

domenic reviewed May 30, 2025

View reviewed changes

Comment thread source Outdated

Comment thread source Outdated

Comment thread source Outdated

Comment thread source Outdated

Comment thread source Outdated

josepharhar and others added 2 commits May 30, 2025 18:11

asdf

29afa58

Final nits

c404530

domenic approved these changes Jun 2, 2025

View reviewed changes

domenic added the topic: dialog The <dialog> element label Jun 2, 2025

chromium-wpt-export-bot mentioned this pull request Jun 3, 2025

Implement ToggleEvent.source for dialog requestclose web-platform-tests/wpt#52935

Merged

chromium-wpt-export-bot mentioned this pull request Jun 4, 2025

Make ToggleEvent.source WPTs non-tentative web-platform-tests/wpt#52967

Merged

Gingeh added a commit to Gingeh/ladybird that referenced this pull request Jun 4, 2025

LibWeb: Implement the ToggleEvent.source attribute

60f5aa0

See: whatwg/html#11186

Gingeh added a commit to Gingeh/ladybird that referenced this pull request Jun 4, 2025

LibWeb: Implement the ToggleEvent.source attribute

75230d9

See: whatwg/html#11186

Gingeh added a commit to Gingeh/ladybird that referenced this pull request Jun 4, 2025

LibWeb: Implement the ToggleEvent.source attribute

4f9db8d

See: whatwg/html#11186

Gingeh added a commit to Gingeh/ladybird that referenced this pull request Jun 5, 2025

LibWeb: Implement the ToggleEvent.source attribute

25c7a94

See: whatwg/html#11186

Gingeh added a commit to Gingeh/ladybird that referenced this pull request Jun 5, 2025

LibWeb: Implement the ToggleEvent.source attribute

82ce3d9

See: whatwg/html#11186

Gingeh added a commit to Gingeh/ladybird that referenced this pull request Jun 5, 2025

LibWeb: Implement the ToggleEvent.source attribute

0de9bbf

See: whatwg/html#11186

Gingeh added a commit to Gingeh/ladybird that referenced this pull request Jun 5, 2025

LibWeb: Implement the ToggleEvent.source attribute

a9b919a

See: whatwg/html#11186

Gingeh added a commit to Gingeh/ladybird that referenced this pull request Jun 5, 2025

LibWeb: Implement the ToggleEvent.source attribute

5e56012

See: whatwg/html#11186

Gingeh added a commit to Gingeh/ladybird that referenced this pull request Jun 6, 2025

LibWeb: Implement the ToggleEvent.source attribute

3450e3e

See: whatwg/html#11186

Gingeh added a commit to Gingeh/ladybird that referenced this pull request Jun 6, 2025

LibWeb: Implement the ToggleEvent.source attribute

d60a19d

See: whatwg/html#11186

Gingeh added a commit to Gingeh/ladybird that referenced this pull request Jun 7, 2025

LibWeb: Implement the ToggleEvent.source attribute

0549617

See: whatwg/html#11186

Gingeh added a commit to Gingeh/ladybird that referenced this pull request Jun 7, 2025

LibWeb: Implement the ToggleEvent.source attribute

bc4a999

See: whatwg/html#11186

tcl3 pushed a commit to LadybirdBrowser/ladybird that referenced this pull request Jun 7, 2025

LibWeb: Implement the ToggleEvent.source attribute

fc35229

See: whatwg/html#11186

keithamus mentioned this pull request Sep 22, 2025

Add source to ToggleEventInit #11679

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add ToggleEvent.source#11186

Add ToggleEvent.source#11186
domenic merged 9 commits into
whatwg:mainfrom
josepharhar:toggleinvoker

josepharhar commented Apr 2, 2025 •

edited by pr-preview Bot

Loading

Uh oh!

domenic commented Apr 3, 2025

Uh oh!

nt1m commented Apr 3, 2025

Uh oh!

josepharhar commented Apr 3, 2025

Uh oh!

keithamus left a comment

Uh oh!

josepharhar commented Apr 23, 2025

Uh oh!

domenic left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

josepharhar commented May 29, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

5 participants

Conversation

josepharhar commented Apr 2, 2025 • edited by pr-preview Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

domenic commented Apr 3, 2025

Uh oh!

nt1m commented Apr 3, 2025

Uh oh!

josepharhar commented Apr 3, 2025

Uh oh!

keithamus left a comment

Choose a reason for hiding this comment

Uh oh!

josepharhar commented Apr 23, 2025

Uh oh!

domenic left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

josepharhar commented May 29, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

5 participants

josepharhar commented Apr 2, 2025 •

edited by pr-preview Bot

Loading

domenic left a comment •

edited

Loading