Implement ToggleEvent.source#52589
Merged
Merged
Conversation
The ToggleEvent's source attribute is set to the element which invoked the element which the ToggleEvent is being fired on. Source can be set up as a parameter passed to element.showPopover(), an element with the popovertarget attribute, or an element with the commandfor attribute. This patch implements support for every element which the ToggleEvent is currently fired on, including <details>, <dialog>, and popovers. Bug: 4080188 Change-Id: I43f3cfe66cfcf077980180d598cfb4ccea6c171e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6427115 Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1461127}
wpt-pr-bot
approved these changes
May 16, 2025
wpt-pr-bot
left a comment
Collaborator
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ToggleEvent's source attribute is set to the element which invoked
the element which the ToggleEvent is being fired on. Source can be set
up as a parameter passed to element.showPopover(), an element with the
popovertarget attribute, or an element with the commandfor attribute.
This patch implements support for every element which the ToggleEvent is
currently fired on, including <details>, <dialog>, and popovers.
Bug: 408018828
Change-Id: I43f3cfe66cfcf077980180d598cfb4ccea6c171e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6427115
Reviewed-by: Mason Freed <masonf@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1461127}