Update the navigation API when a same-document reload occurs#10989
Merged
Conversation
This performs the subset of the "URL and history update steps" that are applicable to reload navigations, in the "inner `navigate` event firing algorithm". Closes whatwg#10621
1bad4e2 to
615797c
Compare
domenic
reviewed
Feb 19, 2025
domenic
left a comment
Member
There was a problem hiding this comment.
Normative content looks good, thanks for working on this. Please be sure to fill out the template with the Chromium bug and some of the tests linked from #10621.
(If we are up for adding more tests, e.g. to test that popstate doesn't fire, that would be excellent. Maybe by completing the TODO in https://github.com/web-platform-tests/wpt/tree/master/navigation-api/ordering-and-transition#navigation-api-orderingtransition-tests to generically add popstate/hashchange test ordering to all those tests.)
For WebKit and Gecko bugs we can just link to the generic navigation API implementation bugs.
noamr
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 19, 2025
As per the spec clarification, soft reloads should only update the navigation API entries but not fire history events. See whatwg/html#10989
Contributor
Author
Done
Added a test (see OP)
Done |
domenic
approved these changes
Feb 20, 2025
noamr
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 20, 2025
…50793) As per the spec clarification, soft reloads should only update the navigation API entries but not fire history events. See whatwg/html#10989
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 27, 2025
When intercepting a navigation with the navigate event, the popstate event should only be fired if the navigation was a traversal (necessarily same-document, since cross-document traversals aren't interceptible), or if the navigation was a same-document fragment navigation (i.e., not originating from the history API or the navigation API). Follows whatwg/html#10989 and whatwg/html#10919 Fixed: 397377454, 398276373 Change-Id: I0f953cd10a8f2a80af0822e9ceafaaac965758fe
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Feb 27, 2025
When intercepting a navigation with the navigate event, the popstate event should only be fired if the navigation was a traversal (necessarily same-document, since cross-document traversals aren't interceptible), or if the navigation was a same-document fragment navigation (i.e., not originating from the history API or the navigation API). Follows whatwg/html#10989 and whatwg/html#10919 Fixed: 397377454, 398276373 Change-Id: I0f953cd10a8f2a80af0822e9ceafaaac965758fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6299859 Reviewed-by: Domenic Denicola <domenic@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/main@{#1425920}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 27, 2025
When intercepting a navigation with the navigate event, the popstate event should only be fired if the navigation was a traversal (necessarily same-document, since cross-document traversals aren't interceptible), or if the navigation was a same-document fragment navigation (i.e., not originating from the history API or the navigation API). Follows whatwg/html#10989 and whatwg/html#10919 Fixed: 397377454, 398276373 Change-Id: I0f953cd10a8f2a80af0822e9ceafaaac965758fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6299859 Reviewed-by: Domenic Denicola <domenic@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/main@{#1425920}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 27, 2025
When intercepting a navigation with the navigate event, the popstate event should only be fired if the navigation was a traversal (necessarily same-document, since cross-document traversals aren't interceptible), or if the navigation was a same-document fragment navigation (i.e., not originating from the history API or the navigation API). Follows whatwg/html#10989 and whatwg/html#10919 Fixed: 397377454, 398276373 Change-Id: I0f953cd10a8f2a80af0822e9ceafaaac965758fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6299859 Reviewed-by: Domenic Denicola <domenic@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/main@{#1425920}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Feb 28, 2025
…on't fire a popstate event, a=testonly Automatic update from web-platform-tests Navigation API: test that soft reloads don't fire a popstate event (#50793) As per the spec clarification, soft reloads should only update the navigation API entries but not fire history events. See whatwg/html#10989 -- wpt-commits: c7802d189273274933bf21947d519505cf521f4d wpt-pr: 50793
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Mar 1, 2025
…on't fire a popstate event, a=testonly Automatic update from web-platform-tests Navigation API: test that soft reloads don't fire a popstate event (#50793) As per the spec clarification, soft reloads should only update the navigation API entries but not fire history events. See whatwg/html#10989 -- wpt-commits: c7802d189273274933bf21947d519505cf521f4d wpt-pr: 50793 UltraBlame original commit: 0b3df17674a5b7f25c03802ee90795df528c0b5c
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Mar 1, 2025
…on't fire a popstate event, a=testonly Automatic update from web-platform-tests Navigation API: test that soft reloads don't fire a popstate event (#50793) As per the spec clarification, soft reloads should only update the navigation API entries but not fire history events. See whatwg/html#10989 -- wpt-commits: c7802d189273274933bf21947d519505cf521f4d wpt-pr: 50793 UltraBlame original commit: 0b3df17674a5b7f25c03802ee90795df528c0b5c
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Mar 1, 2025
…on't fire a popstate event, a=testonly Automatic update from web-platform-tests Navigation API: test that soft reloads don't fire a popstate event (#50793) As per the spec clarification, soft reloads should only update the navigation API entries but not fire history events. See whatwg/html#10989 -- wpt-commits: c7802d189273274933bf21947d519505cf521f4d wpt-pr: 50793 UltraBlame original commit: 0b3df17674a5b7f25c03802ee90795df528c0b5c
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Mar 4, 2025
…te firing behavior, a=testonly Automatic update from web-platform-tests Navigation API: match the spec on popstate firing behavior When intercepting a navigation with the navigate event, the popstate event should only be fired if the navigation was a traversal (necessarily same-document, since cross-document traversals aren't interceptible), or if the navigation was a same-document fragment navigation (i.e., not originating from the history API or the navigation API). Follows whatwg/html#10989 and whatwg/html#10919 Fixed: 397377454, 398276373 Change-Id: I0f953cd10a8f2a80af0822e9ceafaaac965758fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6299859 Reviewed-by: Domenic Denicola <domenic@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/main@{#1425920} -- wpt-commits: 1786c24ad28fd6d2ed33b5f1d9946f2fa75bd648 wpt-pr: 51003
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Mar 5, 2025
…on't fire a popstate event, a=testonly Automatic update from web-platform-tests Navigation API: test that soft reloads don't fire a popstate event (#50793) As per the spec clarification, soft reloads should only update the navigation API entries but not fire history events. See whatwg/html#10989 -- wpt-commits: c7802d189273274933bf21947d519505cf521f4d wpt-pr: 50793
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Mar 5, 2025
…te firing behavior, a=testonly Automatic update from web-platform-tests Navigation API: match the spec on popstate firing behavior When intercepting a navigation with the navigate event, the popstate event should only be fired if the navigation was a traversal (necessarily same-document, since cross-document traversals aren't interceptible), or if the navigation was a same-document fragment navigation (i.e., not originating from the history API or the navigation API). Follows whatwg/html#10989 and whatwg/html#10919 Fixed: 397377454, 398276373 Change-Id: I0f953cd10a8f2a80af0822e9ceafaaac965758fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6299859 Reviewed-by: Domenic Denicola <domenic@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/main@{#1425920} -- wpt-commits: 1786c24ad28fd6d2ed33b5f1d9946f2fa75bd648 wpt-pr: 51003
glandium
pushed a commit
to mozilla-firefox/firefox
that referenced
this pull request
Apr 1, 2025
…on't fire a popstate event, a=testonly Automatic update from web-platform-tests Navigation API: test that soft reloads don't fire a popstate event (#50793) As per the spec clarification, soft reloads should only update the navigation API entries but not fire history events. See whatwg/html#10989 -- wpt-commits: c7802d189273274933bf21947d519505cf521f4d wpt-pr: 50793
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When performing a soft reload (
navigation.reload()orlocation.reload()), the navigation API entries need to be updated to reflect the new state.Note that
popstateand other traversal-related side effects should not occur.Closes #10621
sourceElementmozilla/standards-positions#1154(See WHATWG Working Mode: Changes for more details.)
/nav-history-apis.html ( diff )