Navigation API: test that soft reloads don't fire a popstate event#50793
Merged
Conversation
As per the spec clarification, soft reloads should only update the navigation API entries but not fire history events. See whatwg/html#10989
6 tasks
domenic
approved these changes
Feb 20, 2025
domenic
left a comment
Member
There was a problem hiding this comment.
Looks good, although I'm still hoping we can generically add logging for all popstate and hashchange events and update all of the ordering-and-transition tests to include them at some point.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per the spec clarification, soft reloads should only update the navigation API entries but not fire history events.
See whatwg/html#10989